Add tests of line numbers to causal async stack tests

Add tests of line numbers to causal async stack tests

BUG=
R=devoncarew@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/d264156cfbc0b10f8b687f9407ee05574c4bdc94

[Cutch, 2017-02-14 15:25:50]

Description was changed from

==========
Add tests of line numbers to causal async stack tests

BUG=
==========

to

==========
Add tests of line numbers to causal async stack tests

BUG=
==========

[Cutch, 2017-02-14 15:25:50]

johnmccutchan@google.com changed reviewers:
+ devoncarew@google.com

[Cutch, 2017-02-14 15:27:33]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[devoncarew, 2017-02-14 15:40:36]

lgtm

[rmacnak, 2017-02-14 17:42:21]

lgtm w/ general comment

We don't print a trailing colon if we only have token streams without proper
source (e.g. script snapshots or JIT/AOT app snapshots). Prefer

contains("foo.dart:line")

over

contains(":line:")

[Cutch, 2017-02-15 08:31:06]

On 2017/02/14 17:42:21, rmacnak wrote:
> lgtm w/ general comment
> 
> We don't print a trailing colon if we only have token streams without proper
> source (e.g. script snapshots or JIT/AOT app snapshots). Prefer
> 
> contains("foo.dart:line")
> 
> over
> 
> contains(":line:")

Done.

[hausner, 2017-02-15 08:36:53]

hausner@google.com changed reviewers:
+ hausner@google.com

[hausner, 2017-02-15 08:36:54]

DBC

https://codereview.chromium.org/2694013003/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/causal_async_stack_contents_test.dart
(right):

https://codereview.chromium.org/2694013003/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/causal_async_stack_contents_test.dart:69:
expect(await asyncStack[0].location.toUserString(), contains(':19:'));
DBC: you could use string interpolation to avoid the literal numbers.

... contains(':$LINE_C:') ...

[Cutch, 2017-02-15 08:38:54]

Description was changed from

==========
Add tests of line numbers to causal async stack tests

BUG=
==========

to

==========
Add tests of line numbers to causal async stack tests

BUG=
R=devoncarew@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d264156cfbc0b10f8b687f9407ee05574c4bdc94
==========

[Cutch, 2017-02-15 08:38:56]

Committed patchset #2 (id:20001) manually as
d264156cfbc0b10f8b687f9407ee05574c4bdc94 (presubmit successful).

[Cutch, 2017-02-15 08:39:21]

On 2017/02/15 08:36:54, hausner wrote:
> DBC
> 
>
https://codereview.chromium.org/2694013003/diff/1/runtime/observatory/tests/s...
> File runtime/observatory/tests/service/causal_async_stack_contents_test.dart
> (right):
> 
>
https://codereview.chromium.org/2694013003/diff/1/runtime/observatory/tests/s...
> runtime/observatory/tests/service/causal_async_stack_contents_test.dart:69:
> expect(await asyncStack[0].location.toUserString(), contains(':19:'));
> DBC: you could use string interpolation to avoid the literal numbers.
> 
> ... contains(':$LINE_C:') ...

I didn't see this comment until I had submitted. I agree we can clean these up.