Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1297)

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker_unittest.cc

Issue 2693953005: [scheduler] Disable background thread load tracker by default. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker_unittest.cc b/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker_unittest.cc
index 23072d439fab90516e9476860f7d681a13cddd25..aa3a09550f2bb167b110b1c3b784480c7d74bc91 100644
--- a/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker_unittest.cc
@@ -33,6 +33,7 @@ TEST(ThreadLoadTrackerTest, RecordTasks) {
ThreadLoadTracker thread_load_tracker(
SecondsToTime(1), base::Bind(&AddToVector, base::Unretained(&result)),
base::TimeDelta::FromSeconds(1), base::TimeDelta::FromSeconds(10));
+ thread_load_tracker.Resume(SecondsToTime(1));
// We should discard first ten seconds of information.
thread_load_tracker.RecordTaskTime(SecondsToTime(1), SecondsToTime(3));
@@ -67,6 +68,7 @@ TEST(ThreadLoadTrackerTest, PauseAndResume) {
ThreadLoadTracker thread_load_tracker(
SecondsToTime(1), base::Bind(&AddToVector, base::Unretained(&result)),
base::TimeDelta::FromSeconds(1), base::TimeDelta::FromSeconds(10));
+ thread_load_tracker.Resume(SecondsToTime(1));
thread_load_tracker.RecordTaskTime(SecondsToTime(3), SecondsToTime(4));
thread_load_tracker.Pause(SecondsToTime(5));
@@ -91,5 +93,25 @@ TEST(ThreadLoadTrackerTest, PauseAndResume) {
std::make_pair(SecondsToTime(27), 0.1)));
}
+TEST(ThreadLoadTrackerTest, DisabledByDefault) {
+ std::vector<std::pair<base::TimeTicks, double>> result;
+ ThreadLoadTracker thread_load_tracker(
+ SecondsToTime(1), base::Bind(&AddToVector, base::Unretained(&result)),
+ base::TimeDelta::FromSeconds(1), base::TimeDelta::FromSeconds(10));
+
+ // ThreadLoadTracker should be disabled and these tasks should be
+ // ignored.
+ thread_load_tracker.RecordTaskTime(SecondsToTime(13), SecondsToTime(14));
+ thread_load_tracker.RecordTaskTime(SecondsToTime(15), SecondsToTime(16));
+
+ thread_load_tracker.Resume(SecondsToTime(17));
+
+ thread_load_tracker.RecordTaskTime(SecondsToTime(28), SecondsToTime(29));
+
+ EXPECT_THAT(result, ElementsAre(std::make_pair(SecondsToTime(27), 0),
+ std::make_pair(SecondsToTime(28), 0),
+ std::make_pair(SecondsToTime(29), 1)));
+}
+
} // namespace scheduler
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698