third_party/WebKit/Source/build/scripts/make_computed_style_base.py - Issue 2693933003: Move field-dependent code in ComputedStyleBase to Jinja macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2693933003: Move field-dependent code in ComputedStyleBase to Jinja macros. (Closed)

Patch Set: DRY Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl » ('j') | third_party/WebKit/Source/build/scripts/templates/fields/keyword.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

index 1367b7f18538ba98157805dc5d6def55b0fc608e..5038d27b429200a9aebd119f1755024920a795b3 100755

--- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

+++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

@@ -49,7 +49,7 @@ class Field(object):

'property_name',

# Name of the type (e.g. EClear, int)

'type_name',

- # Affects how the field is generated (keyword, flag)

+ # Affects how the field is generated (keyword, flag, monotonic_flag)

'field_template',

# Bits needed for storage

'size',

@@ -208,7 +208,7 @@ def _create_nonproperty_field(field_name):

name=member_name,

property_name=field_name,

type_name='bool',

- field_template='flag',

+ field_template='monotonic_flag',

size=1,

default_value='false',

getter_method_name=field_name,