third_party/WebKit/Source/build/scripts/templates/fields/base.tmpl - Issue 2693933003: Move field-dependent code in ComputedStyleBase to Jinja macros.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/fields/base.tmpl

Issue 2693933003: Move field-dependent code in ComputedStyleBase to Jinja macros. (Closed)

Patch Set: DRY Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {% macro decl_methods(field) -%}

	2 inline static {{field.type_name}} {{field.initial_method_name}}() {

	3 return {{field.default_value}};

	4 }

	5 {{field.type_name}} {{field.getter_method_name}}() const {

	6 return static_cast<{{field.type_name}}>({{field.name}});

	7 }

	8 void {{field.setter_method_name}}({{field.type_name}} v) {

	9 {{field.name}} = static_cast<unsigned>(v);

	10 }

	11 inline void {{field.resetter_method_name}}() {

	12 {{field.name}} = static_cast<unsigned>({{field.default_value}});

	13 }

	14 {%- endmacro %}

	15

OLD	NEW