Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py

Issue 2693923005: Reland of [Telemetry] Switch clients to new JavaScript API (batch 5) (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py
diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py b/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py
index dc24172fcf48ba33e88487caf69f378257404b4b..8976ac0bdd467162a7029d6b9e8656f45228c435 100644
--- a/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py
+++ b/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py
@@ -351,11 +351,12 @@
continue
context_id = context['id']
backend = context_map.GetInspectorBackend(context_id)
- # TODO(catapult:#3028): Fix interpolation of JavaScript values.
- backend.EvaluateJavaScript(
- "console.time('" + backend.id + "');" +
- "console.timeEnd('" + backend.id + "');" +
- "console.time.toString().indexOf('[native code]') != -1;")
+ backend.EvaluateJavaScript2("""
+ console.time({{ backend_id }});
+ console.timeEnd({{ backend_id }});
+ console.time.toString().indexOf('[native code]') != -1;
+ """,
+ backend_id=backend.id)
self._tab_ids.append(backend.id)
finally:
self._tracing_backend.StopTracing()

Powered by Google App Engine
This is Rietveld 408576698