Reland of [Telemetry] Switch clients to new JavaScript API (batch 5)

telemetry/telemetry/internal/backends/chrome/cros_unittest.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import urllib2
 import os
 
 from telemetry.core import exceptions
 from telemetry import decorators
@@ skipping 83 matching lines @@
       self.assertFalse(login_status['isScreenLocked'])
 
   @decorators.Enabled('chromeos')
   def testLogout(self):
     """Tests autotestPrivate.logout"""
     if self._is_guest:
       return
     with self._CreateBrowser(autotest_ext=True) as b:
       extension = self._GetAutotestExtension(b)
       try:
-        extension.ExecuteJavaScript('chrome.autotestPrivate.logout();')
+        extension.ExecuteJavaScript2('chrome.autotestPrivate.logout();')
       except exceptions.Error:
         pass
       py_utils.WaitFor(lambda: not self._IsCryptohomeMounted(), 20)
 
   @decorators.Disabled('all')
   def testGaiaLogin(self):
     """Tests gaia login. Use credentials in credentials.txt if it exists,
     otherwise use powerloadtest."""
     if self._is_guest:
       return
@@ skipping 31 matching lines @@
 
 
 class CrOSScreenLockerTest(cros_test_case.CrOSTestCase):
   def _IsScreenLocked(self, browser):
     return self._GetLoginStatus(browser)['isScreenLocked']
 
   def _LockScreen(self, browser):
     self.assertFalse(self._IsScreenLocked(browser))
 
     extension = self._GetAutotestExtension(browser)
-    self.assertTrue(extension.EvaluateJavaScript(
+    self.assertTrue(extension.EvaluateJavaScript2(
         "typeof chrome.autotestPrivate.lockScreen == 'function'"))
     logging.info('Locking screen')
-    extension.ExecuteJavaScript('chrome.autotestPrivate.lockScreen();')
+    extension.ExecuteJavaScript2('chrome.autotestPrivate.lockScreen();')
 
     logging.info('Waiting for the lock screen')
     def ScreenLocked():
       return (browser.oobe_exists and
-          browser.oobe.EvaluateJavaScript("typeof Oobe == 'function'") and
-          browser.oobe.EvaluateJavaScript(
-          "typeof Oobe.authenticateForTesting == 'function'"))
+          browser.oobe.EvaluateJavaScript2("typeof Oobe == 'function'") and
+          browser.oobe.EvaluateJavaScript2(
+              "typeof Oobe.authenticateForTesting == 'function'"))
     py_utils.WaitFor(ScreenLocked, 10)
     self.assertTrue(self._IsScreenLocked(browser))
 
   def _AttemptUnlockBadPassword(self, browser):
     logging.info('Trying a bad password')
     def ErrorBubbleVisible():
-      return not browser.oobe.EvaluateJavaScript('''
-          document.getElementById('bubble').hidden
-      ''')
+      return not browser.oobe.EvaluateJavaScript2(
+          "document.getElementById('bubble').hidden")
+
     self.assertFalse(ErrorBubbleVisible())
-    # TODO(catapult:#3028): Fix interpolation of JavaScript values.
-    browser.oobe.ExecuteJavaScript('''
-        Oobe.authenticateForTesting('%s', 'bad');
-    ''' % self._username)
+    browser.oobe.ExecuteJavaScript2(
+        "Oobe.authenticateForTesting({{ username }}, 'bad');",
+        username=self._username)
     py_utils.WaitFor(ErrorBubbleVisible, 10)
     self.assertTrue(self._IsScreenLocked(browser))
 
   def _UnlockScreen(self, browser):
     logging.info('Unlocking')
-    # TODO(catapult:#3028): Fix interpolation of JavaScript values.
-    browser.oobe.ExecuteJavaScript('''
-        Oobe.authenticateForTesting('%s', '%s');
-    ''' % (self._username, self._password))
+    browser.oobe.ExecuteJavaScript2(
+        'Oobe.authenticateForTesting({{ username }}, {{ password }});',
+        username=self._username, password=self._password)
     py_utils.WaitFor(lambda: not browser.oobe_exists, 10)
     self.assertFalse(self._IsScreenLocked(browser))
 
   @decorators.Disabled('all')
   def testScreenLock(self):
     """Tests autotestPrivate.screenLock"""
     if self._is_guest:
       return
     with self._CreateBrowser(autotest_ext=True) as browser:
       self._LockScreen(browser)
       self._AttemptUnlockBadPassword(browser)
       self._UnlockScreen(browser)