Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2343)

Unified Diff: services/ui/demo/mus_demo_internal.cc

Issue 2693923004: Mus Demo: Extract code specific to internal mode into a separate class (Closed)
Patch Set: Address review comments and more refactoring Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« services/ui/demo/mus_demo.h ('K') | « services/ui/demo/mus_demo_internal.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/demo/mus_demo_internal.cc
diff --git a/services/ui/demo/mus_demo_internal.cc b/services/ui/demo/mus_demo_internal.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9bfb14310eb4b4726b8d8ef9c1a26a17e78a4b56
--- /dev/null
+++ b/services/ui/demo/mus_demo_internal.cc
@@ -0,0 +1,107 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "services/ui/demo/mus_demo_internal.h"
+
+#include "services/service_manager/public/cpp/service_context.h"
+#include "services/ui/demo/window_tree_data.h"
+#include "ui/aura/mus/window_tree_client.h"
+#include "ui/aura/mus/window_tree_host_mus.h"
+
+namespace ui {
+namespace demo {
+
+namespace {
+
+// Size of square in pixels to draw.
+const int kSquareSize = 300;
fwang 2017/02/15 17:10:02 per Antonio's comment, I'll change this to unsigne
fwang 2017/02/16 07:48:31 So finally I better not: https://codereview.chromi
+}
+
+MusDemoInternal::MusDemoInternal() {}
+
+MusDemoInternal::~MusDemoInternal() {}
+
+void MusDemoInternal::OnStartImpl(
+ std::unique_ptr<aura::WindowTreeClient>& window_tree_client,
+ std::unique_ptr<WindowTreeData>& window_tree_data) {
+ window_tree_client = base::MakeUnique<aura::WindowTreeClient>(
+ context()->connector(), this, this);
+ window_tree_client->ConnectAsWindowManager();
+ window_tree_data = base::MakeUnique<WindowTreeData>(kSquareSize);
+}
+
+void MusDemoInternal::SetWindowManagerClient(
+ aura::WindowManagerClient* client) {}
+
+bool MusDemoInternal::OnWmSetBounds(aura::Window* window, gfx::Rect* bounds) {
+ return true;
+}
+
+bool MusDemoInternal::OnWmSetProperty(
+ aura::Window* window,
+ const std::string& name,
+ std::unique_ptr<std::vector<uint8_t>>* new_data) {
+ return true;
+}
+
+void MusDemoInternal::OnWmSetCanFocus(aura::Window* window, bool can_focus) {}
+
+aura::Window* MusDemoInternal::OnWmCreateTopLevelWindow(
+ mojom::WindowType window_type,
+ std::map<std::string, std::vector<uint8_t>>* properties) {
+ NOTREACHED();
+ return nullptr;
+}
+
+void MusDemoInternal::OnWmClientJankinessChanged(
+ const std::set<aura::Window*>& client_windows,
+ bool janky) {
+ // Don't care
+}
+
+void MusDemoInternal::OnWmWillCreateDisplay(const display::Display& display) {
+ AddPrimaryDisplay(display);
+}
+
+void MusDemoInternal::OnWmNewDisplay(
+ std::unique_ptr<aura::WindowTreeHostMus> window_tree_host,
+ const display::Display& display) {
+ InitWindowTreeData(std::move(window_tree_host));
+}
+
+void MusDemoInternal::OnWmDisplayRemoved(
+ aura::WindowTreeHostMus* window_tree_host) {
+ CleanupWindowTreeData();
+}
+
+void MusDemoInternal::OnWmDisplayModified(const display::Display& display) {}
+
+mojom::EventResult MusDemoInternal::OnAccelerator(uint32_t id,
+ const Event& event) {
+ return mojom::EventResult::UNHANDLED;
+}
+
+void MusDemoInternal::OnWmPerformMoveLoop(
+ aura::Window* window,
+ mojom::MoveLoopSource source,
+ const gfx::Point& cursor_location,
+ const base::Callback<void(bool)>& on_done) {
+ // Don't care
+}
+
+void MusDemoInternal::OnWmCancelMoveLoop(aura::Window* window) {}
+
+void MusDemoInternal::OnWmSetClientArea(
+ aura::Window* window,
+ const gfx::Insets& insets,
+ const std::vector<gfx::Rect>& additional_client_areas) {}
+
+bool MusDemoInternal::IsWindowActive(aura::Window* window) {
+ return false;
+}
+
+void MusDemoInternal::OnWmDeactivateWindow(aura::Window* window) {}
+
+} // namespace demo
+} // namespace aura
« services/ui/demo/mus_demo.h ('K') | « services/ui/demo/mus_demo_internal.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698