Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1554)

Unified Diff: services/ui/demo/mus_demo_internal.h

Issue 2693923004: Mus Demo: Extract code specific to internal mode into a separate class (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/demo/mus_demo_internal.h
diff --git a/services/ui/demo/mus_demo_internal.h b/services/ui/demo/mus_demo_internal.h
new file mode 100644
index 0000000000000000000000000000000000000000..78f1ed93d2ad47e422994ca3f4403c2558afa746
--- /dev/null
+++ b/services/ui/demo/mus_demo_internal.h
@@ -0,0 +1,58 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SERVICES_UI_DEMO_MUS_DEMO_INTERNAL_H_
+#define SERVICES_UI_DEMO_MUS_DEMO_INTERNAL_H_
+
+#include "services/ui/demo/mus_demo.h"
kylechar 2017/02/14 18:40:11 Missing imports for WindowManagerDelegate and othe
fwang 2017/02/15 13:49:26 Done.
+
+namespace ui {
+namespace demo {
+
+class MusDemoInternal : public MusDemo, public aura::WindowManagerDelegate {
+ public:
+ MusDemoInternal();
kylechar 2017/02/14 18:40:11 You're missing a destructor override.
fwang 2017/02/15 13:49:26 Done.
+
+ private:
+ void OnStartImpl() override;
+
+ // aura::WindowManagerDelegate:
+ void SetWindowManagerClient(aura::WindowManagerClient* client) override;
+ bool OnWmSetBounds(aura::Window* window, gfx::Rect* bounds) override;
+ bool OnWmSetProperty(
+ aura::Window* window,
+ const std::string& name,
+ std::unique_ptr<std::vector<uint8_t>>* new_data) override;
+ void OnWmSetCanFocus(aura::Window* window, bool can_focus) override;
+ aura::Window* OnWmCreateTopLevelWindow(
+ ui::mojom::WindowType window_type,
+ std::map<std::string, std::vector<uint8_t>>* properties) override;
+ void OnWmClientJankinessChanged(const std::set<aura::Window*>& client_windows,
+ bool janky) override;
+ void OnWmWillCreateDisplay(const display::Display& display) override;
+ void OnWmNewDisplay(std::unique_ptr<aura::WindowTreeHostMus> window_tree_host,
+ const display::Display& display) override;
+ void OnWmDisplayRemoved(aura::WindowTreeHostMus* window_tree_host) override;
+ void OnWmDisplayModified(const display::Display& display) override;
+ ui::mojom::EventResult OnAccelerator(uint32_t id,
+ const ui::Event& event) override;
+ void OnWmPerformMoveLoop(aura::Window* window,
+ ui::mojom::MoveLoopSource source,
+ const gfx::Point& cursor_location,
+ const base::Callback<void(bool)>& on_done) override;
+ void OnWmCancelMoveLoop(aura::Window* window) override;
+ void OnWmSetClientArea(
+ aura::Window* window,
+ const gfx::Insets& insets,
+ const std::vector<gfx::Rect>& additional_client_areas) override;
+ bool IsWindowActive(aura::Window* window) override;
+ void OnWmDeactivateWindow(aura::Window* window) override;
+
+ DISALLOW_COPY_AND_ASSIGN(MusDemoInternal);
+};
+
+} // namespace demo
+} // namespace aura
+
+#endif // SERVICES_UI_DEMO_MUS_DEMO_INTERNAL_H_

Powered by Google App Engine
This is Rietveld 408576698