Mus Demo: Extract code specific to internal mode into a separate class

services/ui/demo/mus_demo.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SERVICES_UI_DEMO_MUS_DEMO_H_
 #define SERVICES_UI_DEMO_MUS_DEMO_H_
 
 #include <map>
 #include <memory>
 #include <set>
@@ skipping 26 matching lines @@
 }
 
 namespace ui {
 namespace demo {
 
 // A simple MUS Demo service. This service connects to the service:ui, adds a
 // new window to the root Window, and draws a spinning square in the center of
 // the window. Provides a simple way to demonstrate that the graphic stack works
 // as intended.
 class MusDemo : public service_manager::Service,
-                public aura::WindowTreeClientDelegate,
-                public aura::WindowManagerDelegate {
+                public aura::WindowTreeClientDelegate {

[tonikitoo, 2017/02/14 20:00:43]

so, the resulting MusDemo class still inherits from
aura::WindowTreeClientDelegate, but only stubs out its methods?

It should be ok for this CL, but maybe in
https://codereview.chromium.org/2503923003/ you could also move the inheritance
from MusDemo of WindowTreeClientDelegate to MusDemoExternal.

Then mus_demo.cc/h would only contain MusDemo (base) declaration, that inherits
from service_manager::Service and WindowTreeData class.

[fwang, 2017/02/14 20:47:28]

I think OnLostConnection is implemented in MusDemo.

  public:
   MusDemo();
   ~MusDemo() override;
 
  protected:
+  virtual void OnStartImpl() = 0;
+
   class WindowTreeData {
    public:
     explicit WindowTreeData(
         std::unique_ptr<aura::WindowTreeHostMus> window_tree_host,
         int square_size);
     ~WindowTreeData();
 
    private:
     // Initializes the window tree host and start drawing frames.
     void Init(std::unique_ptr<aura::WindowTreeHostMus> window_tree_host);
@@ skipping 16 matching lines @@
     // Current rotation angle for drawing.
     double angle_ = 0.0;
 
     // Size in pixels of the square to draw.
     const int square_size_;
 
     DISALLOW_COPY_AND_ASSIGN(WindowTreeData);
   };
   std::unique_ptr<WindowTreeData> window_tree_data_;
 
+  std::unique_ptr<display::ScreenBase> screen_;

[kylechar, 2017/02/14 18:40:11]

These must be in the private section.

+  std::unique_ptr<aura::WindowTreeClient> window_tree_client_;
+
  private:
   // service_manager::Service:
   void OnStart() override;
   bool OnConnect(const service_manager::ServiceInfo& remote_info,
                  service_manager::InterfaceRegistry* registry) override;
 
   // aura::WindowTreeClientDelegate:
   void OnEmbed(
       std::unique_ptr<aura::WindowTreeHostMus> window_tree_host) override;
   void OnUnembed(aura::Window* root) override;
   void OnEmbedRootDestroyed(aura::WindowTreeHostMus* window_tree_host) override;
   void OnLostConnection(aura::WindowTreeClient* client) override;
   void OnPointerEventObserved(const ui::PointerEvent& event,
                               aura::Window* target) override;
   aura::PropertyConverter* GetPropertyConverter() override;
 
-  // aura::WindowManagerDelegate:

[kylechar, 2017/02/14 18:40:11]

Remove the includes that were added just for WindowManagerDelegate.

-  void SetWindowManagerClient(aura::WindowManagerClient* client) override;
-  bool OnWmSetBounds(aura::Window* window, gfx::Rect* bounds) override;
-  bool OnWmSetProperty(
-      aura::Window* window,
-      const std::string& name,
-      std::unique_ptr<std::vector<uint8_t>>* new_data) override;
-  void OnWmSetCanFocus(aura::Window* window, bool can_focus) override;
-  aura::Window* OnWmCreateTopLevelWindow(
-      ui::mojom::WindowType window_type,
-      std::map<std::string, std::vector<uint8_t>>* properties) override;
-  void OnWmClientJankinessChanged(const std::set<aura::Window*>& client_windows,
-                                  bool janky) override;
-  void OnWmWillCreateDisplay(const display::Display& display) override;
-  void OnWmNewDisplay(std::unique_ptr<aura::WindowTreeHostMus> window_tree_host,
-                      const display::Display& display) override;
-  void OnWmDisplayRemoved(aura::WindowTreeHostMus* window_tree_host) override;
-  void OnWmDisplayModified(const display::Display& display) override;
-  ui::mojom::EventResult OnAccelerator(uint32_t id,
-                                       const ui::Event& event) override;
-  void OnWmPerformMoveLoop(aura::Window* window,
-                           ui::mojom::MoveLoopSource source,
-                           const gfx::Point& cursor_location,
-                           const base::Callback<void(bool)>& on_done) override;
-  void OnWmCancelMoveLoop(aura::Window* window) override;
-  void OnWmSetClientArea(
-      aura::Window* window,
-      const gfx::Insets& insets,
-      const std::vector<gfx::Rect>& additional_client_areas) override;
-  bool IsWindowActive(aura::Window* window) override;
-  void OnWmDeactivateWindow(aura::Window* window) override;
-
-  std::unique_ptr<aura::WindowTreeClient> window_tree_client_;
   std::unique_ptr<aura::Env> env_;
-  std::unique_ptr<display::ScreenBase> screen_;
 
   std::unique_ptr<aura::client::DefaultCaptureClient> capture_client_;
   std::unique_ptr<::wm::WMState> wm_state_;
   std::unique_ptr<aura::PropertyConverter> property_converter_;
 
   DISALLOW_COPY_AND_ASSIGN(MusDemo);
 };
 
 }  // namespace demo
 }  // namespace aura
 
 #endif  // SERVICES_UI_DEMO_MUS_DEMO_H_