Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h

Issue 2693893007: binding: Changes the association among global-proxy/global/window-instance (2nd attempt). (Closed)
Patch Set: Fixed a typo in DOMWrapperWorld::DissociateDOMWindowWrappersInAllWorlds. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h b/third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h
index 7fd0ba86d731daeb018001db605e6c90f47bb165..cc6597ce1d79467196aef2bee2172dd7c4ce5a29 100644
--- a/third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h
+++ b/third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h
@@ -180,8 +180,8 @@ struct WrapperTypeInfo {
const WrapperTypeInfo* parent_class;
const unsigned wrapper_type_prototype : 1; // WrapperTypePrototype
const unsigned wrapper_class_id : 2; // WrapperClassId
- const unsigned
- active_script_wrappable_inheritance : 1; // ActiveScriptWrappableInheritance
+ const unsigned // ActiveScriptWrappableInheritance
+ active_script_wrappable_inheritance : 1;
const unsigned lifetime : 1; // Lifetime
};
@@ -199,6 +199,8 @@ inline T* GetInternalField(v8::Local<v8::Object> wrapper) {
wrapper->GetAlignedPointerFromInternalField(offset));
}
+// The return value can be null if |wrapper| is a global proxy, which points to
+// nothing while a navigation.
inline ScriptWrappable* ToScriptWrappable(
const v8::PersistentBase<v8::Object>& wrapper) {
return GetInternalField<ScriptWrappable, kV8DOMWrapperObjectIndex>(wrapper);
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/WindowProxy.h ('k') | third_party/WebKit/Source/core/dom/Document.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698