Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2693893003: Introduce EnqueuerListener (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce EnqueuerListener - to abstract the JavaScriptBackend coupling to Enqueuer R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/4ada4dbb99a89567a79fe751a853dd4ac91a5bca

Patch Set 1 #

Patch Set 2 : dartfmt #

Patch Set 3 : Make listener private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -87 lines) Patch
M pkg/compiler/lib/src/enqueue.dart View 1 2 13 chunks +79 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 8 chunks +8 lines, -35 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 2 2 chunks +34 lines, -24 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 1 2 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-13 14:04:10 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-14 23:39:20 UTC) #3
Johnni Winther
3 years, 10 months ago (2017-02-20 10:53:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4ada4dbb99a89567a79fe751a853dd4ac91a5bca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698