VM: Restore old implementation of ClassID.cid* fields

VM: Restore old implementation of ClassID.cid* fields.

When we were implementing bootstraping from Kernel in https://github.com/dart-lang/sdk/commit/23fd1a184b393825f29444243780f3593ce0b3c1 we switched ClassID.cid* fields to become 'static final' lazily initialized fields instead of constants as they were before. This was mainly done to allow dartk compile patched_sdk - because these fields were previously injected in runtime and never existed in the text form.

However this regressed code quality for app-jit and app-aot snapshots because 'static final' fields are reset by snapshotting so resulting code contains InitStaticField and LoadStaticField instructions.

BUG=
R=kustermann@google.com

Committed: https://github.com/dart-lang/sdk/commit/364b8575de8718940a0afa16549329aab6ea9674

[Vyacheslav Egorov (Google), 2017-02-16 15:49:35]

Description was changed from

==========
VM: Specialize getters of ClassID.cid* fields in the parser / kernel IL builder.

BUG=
==========

to

==========
VM: Restore old implementation of ClassID.cid* fields.

When we were implementing bootstraping from Kernel in
https://github.com/dart-lang/sdk/commit/23fd1a184b393825f29444243780f3593ce0b3c1
we switched ClassID.cid* fields to become 'static final' lazily initialized
fields instead of constants as they were before. This was mainly done to allow
dartk compile patched_sdk - because these fields were previously injected in
runtime and never existed in the text form. 

However this regressed code quality for app-jit and app-aot snapshots because
'static final' fields are reset by snapshotting so resulting code contains
InitStaticField and LoadStaticField instructions.

BUG=
==========

[Vyacheslav Egorov (Google), 2017-02-16 15:49:35]

vegorov@google.com changed reviewers:
+ kustermann@google.com

[Vyacheslav Egorov (Google), 2017-02-16 15:49:43]

PTAL

[kustermann, 2017-02-16 15:59:45]

lgtm :-/

https://codereview.chromium.org/2693863006/diff/20001/tools/patch_sdk.dart
File tools/patch_sdk.dart (right):

https://codereview.chromium.org/2693863006/diff/20001/tools/patch_sdk.dart#ne...
tools/patch_sdk.dart:260: final injectedCidFields = [
String

https://codereview.chromium.org/2693863006/diff/20001/tools/patch_sdk.dart#ne...
tools/patch_sdk.dart:285: // make core libraries compile. Kernel reader will
actually ignore this
this -> these

[Vyacheslav Egorov (Google), 2017-02-16 15:59:57]

Peter, this change FYI.

[ahe, 2017-02-16 16:07:04]

On 2017/02/16 15:59:57, Vyacheslav Egorov (Google) wrote:
> Peter, this change FYI.

Thank you. Having the old version of class_id.dart to look at will help me.

[Vyacheslav Egorov (Google), 2017-02-16 16:43:46]

Description was changed from

==========
VM: Restore old implementation of ClassID.cid* fields.

When we were implementing bootstraping from Kernel in
https://github.com/dart-lang/sdk/commit/23fd1a184b393825f29444243780f3593ce0b3c1
we switched ClassID.cid* fields to become 'static final' lazily initialized
fields instead of constants as they were before. This was mainly done to allow
dartk compile patched_sdk - because these fields were previously injected in
runtime and never existed in the text form. 

However this regressed code quality for app-jit and app-aot snapshots because
'static final' fields are reset by snapshotting so resulting code contains
InitStaticField and LoadStaticField instructions.

BUG=
==========

to

==========
VM: Restore old implementation of ClassID.cid* fields.

When we were implementing bootstraping from Kernel in
https://github.com/dart-lang/sdk/commit/23fd1a184b393825f29444243780f3593ce0b3c1
we switched ClassID.cid* fields to become 'static final' lazily initialized
fields instead of constants as they were before. This was mainly done to allow
dartk compile patched_sdk - because these fields were previously injected in
runtime and never existed in the text form.

However this regressed code quality for app-jit and app-aot snapshots because
'static final' fields are reset by snapshotting so resulting code contains
InitStaticField and LoadStaticField instructions.

BUG=
R=kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/364b8575de8718940a0afa16549329aab6ea9674
==========

[Vyacheslav Egorov (Google), 2017-02-16 16:43:47]

Committed patchset #3 (id:40001) manually as
364b8575de8718940a0afa16549329aab6ea9674 (presubmit successful).