Chromium Code Reviews| Index: ios/chrome/browser/ui/browser_view_controller.mm |
| diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm |
| index f7fd1da28719c31c80dccc4808575a1e31435004..5d315a3c0a0f7f47c468524671209141a75d0f6a 100644 |
| --- a/ios/chrome/browser/ui/browser_view_controller.mm |
| +++ b/ios/chrome/browser/ui/browser_view_controller.mm |
| @@ -133,8 +133,8 @@ |
| #import "ios/chrome/browser/ui/print/print_controller.h" |
| #import "ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller.h" |
| #import "ios/chrome/browser/ui/reading_list/offline_page_native_content.h" |
| +#import "ios/chrome/browser/ui/reading_list/reading_list_coordinator.h" |
| #import "ios/chrome/browser/ui/reading_list/reading_list_menu_notifier.h" |
| -#import "ios/chrome/browser/ui/reading_list/reading_list_view_controller_builder.h" |
| #include "ios/chrome/browser/ui/rtl_geometry.h" |
| #import "ios/chrome/browser/ui/side_swipe/side_swipe_controller.h" |
| #import "ios/chrome/browser/ui/stack_view/card_view.h" |
| @@ -403,6 +403,9 @@ FindInPageController* GetFindInPageController(Tab* tab) { |
| // Used to display the QR Scanner UI. Nil if not visible. |
| base::scoped_nsobject<QRScannerViewController> _qrScannerViewController; |
| + // Used to display the Reading List. |
| + base::scoped_nsobject<ReadingListCoordinator> _readingListCoordinator; |
| + |
| // Used to display the Suggestions. |
| base::scoped_nsobject<ContentSuggestionsCoordinator> |
| _contentSuggestionsCoordinator; |
| @@ -4228,10 +4231,12 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver { |
| - (void)showReadingList { |
| DCHECK(reading_list::switches::IsReadingListEnabled()); |
| - UIViewController* vc = [ReadingListViewControllerBuilder |
| - readingListViewControllerInBrowserState:self.browserState |
| - loader:self]; |
| - [self presentViewController:vc animated:YES completion:nil]; |
| + _readingListCoordinator.reset([[ReadingListCoordinator alloc] |
|
Olivier
2017/02/16 15:16:09
SHould this be released at some point?
gambard
2017/02/16 15:45:56
What do you mean? It is a scoped_nsobject.
Olivier
2017/02/17 14:12:34
If you show the screen, it will only be dealloced
gambard
2017/02/17 15:47:58
Yes, but we don't want BVC to handle all coordinat
|
| + initWithBaseViewController:self |
| + browserState:self.browserState |
| + loader:self]); |
| + |
| + [_readingListCoordinator start]; |
| } |
| - (void)showQRScanner { |