Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm

Issue 2693863005: Create ReadingListCoordinator (Closed)
Patch Set: Address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
diff --git a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
index 85237d7b4da51da0fcad0d6e59c81793bd52e61f..2ff56c1a20ba5315f9ac0702b4fb7cdcc39721ea 100644
--- a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
@@ -175,12 +175,16 @@ using ItemsMapByDate = std::multimap<int64_t, ReadingListCollectionViewItem*>;
@end
@implementation ReadingListCollectionViewController
+
+@synthesize audience = _audience;
+@synthesize delegate = _delegate;
+
@synthesize readingListModel = _readingListModel;
@synthesize largeIconService = _largeIconService;
@synthesize readingListDownloadService = _readingListDownloadService;
@synthesize attributesProvider = _attributesProvider;
-@synthesize delegate = _delegate;
@synthesize shouldMonitorModel = _shouldMonitorModel;
+
#pragma mark lifecycle
- (instancetype)initWithModel:(ReadingListModel*)model
@@ -228,13 +232,11 @@ using ItemsMapByDate = std::multimap<int64_t, ReadingListCollectionViewItem*>;
[_toolbar setState:toolbarState];
}
-- (void)setDelegate:(id<ReadingListCollectionViewControllerDelegate>)delegate {
- _delegate = delegate;
- if (self.readingListModel->loaded())
- [delegate
- readingListCollectionViewController:self
- hasItems:(self.readingListModel->size() >
- 0)];
+- (void)setAudience:(id<ReadingListCollectionViewControllerAudience>)audience {
+ _audience = audience;
+ if (self.readingListModel->loaded()) {
+ [audience readingListHasItems:(self.readingListModel->size() > 0)];
+ }
}
#pragma mark - UIViewController
@@ -412,7 +414,7 @@ using ItemsMapByDate = std::multimap<int64_t, ReadingListCollectionViewItem*>;
self.collectionView.alwaysBounceVertical = YES;
[self loadItems];
self.collectionView.backgroundView = nil;
- [self.delegate readingListCollectionViewController:self hasItems:YES];
+ [self.audience readingListHasItems:YES];
}
}
@@ -546,7 +548,7 @@ using ItemsMapByDate = std::multimap<int64_t, ReadingListCollectionViewItem*>;
// The collection is empty, add background.
self.collectionView.alwaysBounceVertical = NO;
self.collectionView.backgroundView = _emptyCollectionBackground;
- [self.delegate readingListCollectionViewController:self hasItems:NO];
+ [self.audience readingListHasItems:NO];
}
- (void)handleLongPress:(UILongPressGestureRecognizer*)gestureRecognizer {

Powered by Google App Engine
This is Rietveld 408576698