Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2693863005: Create ReadingListCoordinator (Closed)
Patch Set: Address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/reading_list/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index f7fd1da28719c31c80dccc4808575a1e31435004..f8fd36417ce6c024cd1a6b002a1ef6cc5916a9c1 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -133,8 +133,8 @@
#import "ios/chrome/browser/ui/print/print_controller.h"
#import "ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller.h"
#import "ios/chrome/browser/ui/reading_list/offline_page_native_content.h"
+#import "ios/chrome/browser/ui/reading_list/reading_list_coordinator.h"
#import "ios/chrome/browser/ui/reading_list/reading_list_menu_notifier.h"
-#import "ios/chrome/browser/ui/reading_list/reading_list_view_controller_builder.h"
#include "ios/chrome/browser/ui/rtl_geometry.h"
#import "ios/chrome/browser/ui/side_swipe/side_swipe_controller.h"
#import "ios/chrome/browser/ui/stack_view/card_view.h"
@@ -403,6 +403,9 @@ FindInPageController* GetFindInPageController(Tab* tab) {
// Used to display the QR Scanner UI. Nil if not visible.
base::scoped_nsobject<QRScannerViewController> _qrScannerViewController;
+ // Used to display the Reading List.
+ base::scoped_nsobject<ReadingListCoordinator> _readingListCoordinator;
+
// Used to display the Suggestions.
base::scoped_nsobject<ContentSuggestionsCoordinator>
_contentSuggestionsCoordinator;
@@ -1281,7 +1284,9 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
self.typingShield = nil;
if (_voiceSearchController.get())
_voiceSearchController->SetDelegate(nil);
+ _contentSuggestionsCoordinator.reset();
_qrScannerViewController.reset();
+ _readingListCoordinator.reset();
_toolbarController.reset();
_toolbarModelDelegate.reset();
_toolbarModelIOS.reset();
@@ -4228,10 +4233,12 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
- (void)showReadingList {
DCHECK(reading_list::switches::IsReadingListEnabled());
- UIViewController* vc = [ReadingListViewControllerBuilder
- readingListViewControllerInBrowserState:self.browserState
- loader:self];
- [self presentViewController:vc animated:YES completion:nil];
+ _readingListCoordinator.reset([[ReadingListCoordinator alloc]
+ initWithBaseViewController:self
+ browserState:self.browserState
+ loader:self]);
+
+ [_readingListCoordinator start];
}
- (void)showQRScanner {
« no previous file with comments | « no previous file | ios/chrome/browser/ui/reading_list/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698