Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2693853002: Revert "Remove scopedvector in //components/discardable_memory/" (Closed)

Created:
3 years, 10 months ago by tyoshino (SeeGerritForStatus)
Modified:
3 years, 10 months ago
Reviewers:
ke.he
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Remove scopedvector in //components/discardable_memory/" This reverts commit 5ecd5001e88fb71afa47aa7431e63e801ba5d644. R=ke.he@intel.com BUG=691457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M components/discardable_memory/common/discardable_shared_memory_heap.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/discardable_memory/common/discardable_shared_memory_heap.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M components/discardable_memory/common/discardable_shared_memory_heap_perftest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tyoshino (SeeGerritForStatus)
3 years, 10 months ago (2017-02-13 07:16:55 UTC) #1
tyoshino (SeeGerritForStatus)
Please take a look at "Win10 Tests x64" bot. https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64?numbuilds=200 A lots of test are ...
3 years, 10 months ago (2017-02-13 07:19:38 UTC) #2
tyoshino (SeeGerritForStatus)
https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/8327 has lots of unit_tests items shown as failed. According to the flakiness dashboard, ChromeBlacklistTrialTest ...
3 years, 10 months ago (2017-02-13 07:27:29 UTC) #3
tyoshino (SeeGerritForStatus)
Abandoned. See the bug for details. Thanks.
3 years, 10 months ago (2017-02-13 08:03:09 UTC) #5
ke.he
On 2017/02/13 08:03:09, tyoshino wrote: > Abandoned. See the bug for details. Thanks. Hi, tyoshino, ...
3 years, 10 months ago (2017-02-13 08:12:33 UTC) #6
tyoshino (SeeGerritForStatus)
3 years, 10 months ago (2017-02-13 08:16:24 UTC) #7
Message was sent while issue was closed.
On 2017/02/13 08:12:33, ke.he wrote:
> On 2017/02/13 08:03:09, tyoshino wrote:
> > Abandoned. See the bug for details. Thanks.
> 
> Hi, tyoshino,
> My apologize for the reverting, I'll have a check soon.

No worry! It seems I was wrong. This revert patch has been abandoned!

Powered by Google App Engine
This is Rietveld 408576698