Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm

Issue 2693803003: [Mac] LocationBarDecoration MouseUp Fix (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
index e8a0f19194796770c961b1cfa88ae0b1b9e282b6..9b8f00e685df34b184693414fca022ab1cf65395 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
@@ -273,6 +273,10 @@ void LocationBarDecoration::OnMouseDown() {
}
void LocationBarDecoration::OnMouseUp() {
+ // Ignore the mouse up if it's not associated with a mouse down event.
+ if (state_ != DecorationMouseState::PRESSED)
+ return;
+
DCHECK(tracking_area_owner_);
state_ = [tracking_area_ mouseInsideTrackingAreaForView:tracking_area_owner_]
? DecorationMouseState::HOVER
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698