Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3377)

Unified Diff: chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc

Issue 2693803002: Fix position of permission bubbles anchored off the padlock. (Closed)
Patch Set: Share some logic Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc
diff --git a/chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc b/chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc
index d231511be4b641664816f8d2312fde9ce9b86f09..6830f6da0ebed65be4c6805d267224cf7be1d97d 100644
--- a/chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc
+++ b/chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc
@@ -29,9 +29,7 @@ views::View* PermissionPromptImpl::GetAnchorView() {
BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser_);
Peter Kasting 2017/02/13 21:36:31 Nit: This is only used if the conditional succeeds
tapted 2017/02/14 04:00:27 Done. (inverted condition - added an early exit)
if (browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR))
- return browser_view->GetLocationBarView()
- ->location_icon_view()
- ->GetImageView();
+ return browser_view->GetLocationBarView()->GetSecurityBubbleAnchorView();
// Fall back to GetAnchorPoint().
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698