Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/browser/ui/views/location_bar/location_bar_view.h

Issue 2693803002: Fix position of permission bubbles anchored off the padlock. (Closed)
Patch Set: fix ternary if-else (+respond to comments) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 // focused. Used when the toolbar is in full keyboard accessibility mode. 190 // focused. Used when the toolbar is in full keyboard accessibility mode.
191 // Repaints if necessary. 191 // Repaints if necessary.
192 virtual void SetShowFocusRect(bool show); 192 virtual void SetShowFocusRect(bool show);
193 193
194 // Select all of the text. Needed when the user tabs through controls 194 // Select all of the text. Needed when the user tabs through controls
195 // in the toolbar in full keyboard accessibility mode. 195 // in the toolbar in full keyboard accessibility mode.
196 virtual void SelectAll(); 196 virtual void SelectAll();
197 197
198 LocationIconView* location_icon_view() { return location_icon_view_; } 198 LocationIconView* location_icon_view() { return location_icon_view_; }
199 199
200 // Return the point suitable for anchoring location-bar-anchored bubbles at. 200 // Where InfoBar arrows should point. The point will be returned in the
201 // The point will be returned in the coordinates of the LocationBarView. 201 // coordinates of the LocationBarView.
202 gfx::Point GetLocationBarAnchorPoint() const; 202 gfx::Point GetInfoBarAnchorPoint() const;
203
204 // The anchor view for security-related bubbles. That is, those anchored to
205 // the leading edge of the Omnibox, under the padlock.
206 views::View* GetSecurityBubbleAnchorView();
203 207
204 OmniboxViewViews* omnibox_view() { return omnibox_view_; } 208 OmniboxViewViews* omnibox_view() { return omnibox_view_; }
205 const OmniboxViewViews* omnibox_view() const { return omnibox_view_; } 209 const OmniboxViewViews* omnibox_view() const { return omnibox_view_; }
206 210
207 // Returns the position and width that the popup should be, and also the left 211 // Returns the position and width that the popup should be, and also the left
208 // edge that the results should align themselves to (which will leave some 212 // edge that the results should align themselves to (which will leave some
209 // border on the left of the popup). |top_edge_overlap| specifies the number 213 // border on the left of the popup). |top_edge_overlap| specifies the number
210 // of pixels the top edge of the popup should overlap the bottom edge of 214 // of pixels the top edge of the popup should overlap the bottom edge of
211 // the toolbar. 215 // the toolbar.
212 void GetOmniboxPopupPositioningInfo(gfx::Point* top_left_screen_coord, 216 void GetOmniboxPopupPositioningInfo(gfx::Point* top_left_screen_coord,
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
459 BooleanPrefMember edit_bookmarks_enabled_; 463 BooleanPrefMember edit_bookmarks_enabled_;
460 464
461 // This is a debug state variable that stores if the WebContents was null 465 // This is a debug state variable that stores if the WebContents was null
462 // during the last RefreshPageAction. 466 // during the last RefreshPageAction.
463 bool web_contents_null_at_last_refresh_; 467 bool web_contents_null_at_last_refresh_;
464 468
465 DISALLOW_COPY_AND_ASSIGN(LocationBarView); 469 DISALLOW_COPY_AND_ASSIGN(LocationBarView);
466 }; 470 };
467 471
468 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_ 472 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698