Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3367)

Unified Diff: cc/ipc/cc_param_traits.cc

Issue 2693723002: cc: Move output color space from DrawingFrame to RenderPass (Closed)
Patch Set: Fix typo Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/ipc/cc_param_traits_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/ipc/cc_param_traits.cc
diff --git a/cc/ipc/cc_param_traits.cc b/cc/ipc/cc_param_traits.cc
index 495534a5a8cd3ea4a3283f84ec99c49d30f3a71d..4c562f4c3bac214b33259e193a2a6b527a45a739 100644
--- a/cc/ipc/cc_param_traits.cc
+++ b/cc/ipc/cc_param_traits.cc
@@ -328,6 +328,7 @@ void ParamTraits<cc::RenderPass>::Write(base::Pickle* m, const param_type& p) {
WriteParam(m, p.transform_to_root_target);
WriteParam(m, p.filters);
WriteParam(m, p.background_filters);
+ WriteParam(m, p.color_space);
WriteParam(m, p.has_transparent_background);
WriteParam(m, base::checked_cast<uint32_t>(p.quad_list.size()));
@@ -437,6 +438,7 @@ bool ParamTraits<cc::RenderPass>::Read(const base::Pickle* m,
gfx::Transform transform_to_root_target;
cc::FilterOperations filters;
cc::FilterOperations background_filters;
+ gfx::ColorSpace color_space;
bool has_transparent_background;
uint32_t quad_list_size;
@@ -445,12 +447,13 @@ bool ParamTraits<cc::RenderPass>::Read(const base::Pickle* m,
!ReadParam(m, iter, &transform_to_root_target) ||
!ReadParam(m, iter, &filters) ||
!ReadParam(m, iter, &background_filters) ||
+ !ReadParam(m, iter, &color_space) ||
!ReadParam(m, iter, &has_transparent_background) ||
!ReadParam(m, iter, &quad_list_size))
return false;
p->SetAll(id, output_rect, damage_rect, transform_to_root_target, filters,
- background_filters, has_transparent_background);
+ background_filters, color_space, has_transparent_background);
dcheng 2017/02/13 22:47:45 Just curious, but how come ParamTraits uses SetAll
for (uint32_t i = 0; i < quad_list_size; ++i) {
cc::DrawQuad::Material material;
@@ -537,6 +540,8 @@ void ParamTraits<cc::RenderPass>::Log(const param_type& p, std::string* l) {
l->append(", ");
LogParam(p.background_filters, l);
l->append(", ");
+ LogParam(p.color_space, l);
+ l->append(", ");
LogParam(p.has_transparent_background, l);
l->append(", ");
« no previous file with comments | « no previous file | cc/ipc/cc_param_traits_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698