Issue 26937003: Update upload.py from Rietveld @ 73805c4878a9.

Issue 26937003: Update upload.py from Rietveld @ 73805c4878a9. (Closed)

Created:
7 years, 2 months ago by M-A Ruel

Modified:
7 years, 2 months ago

Reviewers:
Mike Stip (use stip instead), ghost stip (do not use), ojan

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, ojan

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Update upload.py from Rietveld @ 73805c4878a9. TBR=stip@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=229012

Patch Set 1 #

Total comments: 5

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -21 lines)			Patch
		third_party/upload.py	View		7 chunks	+68 lines, -21 lines	5 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

ghost stip (do not use)

https://codereview.chromium.org/26937003/diff/1/third_party/upload.py File third_party/upload.py (right): https://codereview.chromium.org/26937003/diff/1/third_party/upload.py#newcode1184 third_party/upload.py:1184: so it normally would have raised an exception, but ...

7 years, 2 months ago (2013-10-16 22:33:33 UTC) #2

ojan

https://codereview.chromium.org/26937003/diff/1/third_party/upload.py File third_party/upload.py (right): https://codereview.chromium.org/26937003/diff/1/third_party/upload.py#newcode1184 third_party/upload.py:1184: The next line will sys.exit. https://codereview.chromium.org/26937003/diff/1/third_party/upload.py#newcode2256 third_party/upload.py:2256: On 2013/10/16 ...

7 years, 2 months ago (2013-10-16 22:39:31 UTC) #3

ghost stip (do not use)

lgtm https://codereview.chromium.org/26937003/diff/1/third_party/upload.py File third_party/upload.py (right): https://codereview.chromium.org/26937003/diff/1/third_party/upload.py#newcode1184 third_party/upload.py:1184: On 2013/10/16 22:39:32, ojan wrote: > The next ...

7 years, 2 months ago (2013-10-16 22:55:00 UTC) #4

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 2 months ago (2013-10-17 00:49:01 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/26937003/1

7 years, 2 months ago (2013-10-17 00:50:12 UTC) #7

Message was sent while issue was closed.

Change committed as 229012

Expand Messages | Collapse Messages