Add some analysis excludes for pkg/front_end.

Add some analysis excludes for pkg/front_end.

BUG=
R=paulberry@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/7f2421094652cf5976a0c14b39dbf5724439f35c

[devoncarew, 2017-02-11 00:05:34]

devoncarew@google.com changed reviewers:
+ paulberry@google.com

[devoncarew, 2017-02-11 00:05:34]

- update the .analysis_options file to add analysis excludes for lib/src/fasta
and test/fasta

If there's a better way analyze this package, I'll all ears! Right now loading
it up in IntelliJ shows a lot of analysis issues (with or without  strong mode
enabled).

[Siggi Cherem (dart-lang), 2017-02-11 00:39:47]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-02-11 00:39:47]

I'm surprised - do you see the same problem on the command line too?

THis should have been fixed with my change ealier today
(https://github.com/dart-lang/sdk/commit/935ec2bb8948f142c7843a4eaa6f1aa09213c408)

I'm running:

sdk/bin/dartanalyzer --options pkg/front_end/.analysis_options
pkg/front_end/lib/src/fasta/  | sort -u

which gives me 2 messages (1 error and 1 hint)

[Paul Berry, 2017-02-12 14:42:50]

On 2017/02/11 00:39:47, Siggi Cherem (dart-lang) wrote:
> I'm surprised - do you see the same problem on the command line too?
> 
> THis should have been fixed with my change ealier today
>
(https://github.com/dart-lang/sdk/commit/935ec2bb8948f142c7843a4eaa6f1aa09213c408)
> 
> I'm running:
> 
> sdk/bin/dartanalyzer --options pkg/front_end/.analysis_options
> pkg/front_end/lib/src/fasta/  | sort -u
> 
> which gives me 2 messages (1 error and 1 hint)

I still see a lot of errors in pkg/front_end/test/fasta, which IIRC the front
end team decided not to fix :(.  So excluding that directory seems ok to me.

But we shouldn't exclude pkg/front_end/lib/src/fasta.  That has only two errors
which AFAIK are being worked on.

[devoncarew, 2017-02-12 17:17:01]

> sdk/bin/dartanalyzer --options pkg/front_end/.analysis_options
pkg/front_end/lib/src/fasta/  | sort -u

I just see a few if I use the above command-line. I see many more if I instead
analyze all of pkg/front_end.

Updated this CL to just filter the test/fasta dir analysis issues.

[Siggi Cherem (dart-lang), 2017-02-13 05:11:23]

lgtm

Ah yes, this makes sense now. The test folder currently contains a lot of .dart
files that are input for tests, not actual programs, so they are expected to
have lots of errors. I once analyzed all the files that are named *_test.dart
and those were warning free at the time. It's possible that just adding a
subfolder with all the data input might give us a clean split here.

[ahe, 2017-02-13 06:25:37]

The files in pkg/front_end/test/fasta/rasta contains error-recovery tests, and
thus may contain errors.

The rest of the files should be warning free, but I have only been checking some
of the files.

[Paul Berry, 2017-02-13 13:45:27]

lgtm

[devoncarew, 2017-02-13 14:30:11]

Description was changed from

==========
Add some analysis excludes for pkg/front_end.

BUG=
==========

to

==========
Add some analysis excludes for pkg/front_end.

BUG=
R=paulberry@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7f2421094652cf5976a0c14b39dbf5724439f35c
==========

[devoncarew, 2017-02-13 14:30:12]

Committed patchset #2 (id:20001) manually as
7f2421094652cf5976a0c14b39dbf5724439f35c (presubmit successful).

[devoncarew, 2017-02-13 14:33:06]

> The files in pkg/front_end/test/fasta/rasta contains error-recovery tests

Excluding just that dir does drop the remaining error count to ~30 issues. From
spot checking the remaining items, some look like legitimate problems, and some
like negative tests that are outside the rasta dir.