Source/platform/scroll/ScrollbarThemeClient.h - Issue 26936002: Remove Widget's dependency upon its own inheritor aka ScrollView. This was nasty from an OO design…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/ScrollbarThemeClient.h

Issue 26936002: Remove Widget's dependency upon its own inheritor aka ScrollView. This was nasty from an OO design… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Clean up by using helper functions where appropriate Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/scroll/ScrollbarThemeClient.h

diff --git a/Source/platform/scroll/ScrollbarThemeClient.h b/Source/platform/scroll/ScrollbarThemeClient.h

index 50cde48ebe99f18ee49bdc2ae33bed94056f5d60..b45647a8190bd100c80c6a42d7272f5c019ad0d2 100644

--- a/Source/platform/scroll/ScrollbarThemeClient.h

+++ b/Source/platform/scroll/ScrollbarThemeClient.h

@@ -35,7 +35,7 @@

namespace WebCore {

-class ScrollView;

+class Widget;

class ScrollbarThemeClient {

public:

@@ -46,8 +46,8 @@ public:

virtual IntSize size() const = 0;

virtual IntPoint location() const = 0;

- virtual ScrollView* parent() const = 0;

- virtual ScrollView* root() const = 0;

+ virtual Widget* parent() const = 0;

+ virtual Widget* root() const = 0;

virtual void setFrameRect(const IntRect&) = 0;

virtual IntRect frameRect() const = 0;

« Source/core/platform/Widget.h ('K') | « Source/core/rendering/RenderWidget.cpp ('k') | Source/web/WebInputEventConversion.cpp » ('j') | no next file with comments »