Remove Widget's dependency upon its own inheritor aka ScrollView. This was nasty from an OO design…

Source/web/WebPluginContainerImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 106 matching lines @@
     if (!parent())
         return;
 
     // Don't paint anything if the plugin doesn't intersect the damage rect.
     if (!frameRect().intersects(damageRect))
         return;
 
     gc->save();
 
     ASSERT(parent()->isFrameView());
-    ScrollView* view = parent();
+    ScrollView* view =  toScrollView(parent());
 
     // The plugin is positioned in window coordinates, so it needs to be painted
     // in window coordinates.
     IntPoint origin = view->contentsToWindow(IntPoint(0, 0));
     gc->translate(static_cast<float>(-origin.x()), static_cast<float>(-origin.y()));
 
     WebCanvas* canvas = gc->canvas();
 
     IntRect windowRect = view->contentsToWindow(damageRect);
     m_webPlugin->paint(canvas, windowRect);
@@ skipping 101 matching lines @@
     if (isParentVisible() == parentVisible)
         return;  // No change.
 
     Widget::setParentVisible(parentVisible);
     if (!isSelfVisible())
         return;  // This widget has explicitely been marked as not visible.
 
     m_webPlugin->updateVisibility(isVisible());
 }
 
-void WebPluginContainerImpl::setParent(ScrollView* view)
+void WebPluginContainerImpl::setParent(Widget* widget)
 {
     // We override this function so that if the plugin is windowed, we can call
     // NPP_SetWindow at the first possible moment.  This ensures that
     // NPP_SetWindow is called before the manual load data is sent to a plugin.
     // If this order is reversed, Flash won't load videos.
 
-    Widget::setParent(view);
-    if (view)
+    Widget::setParent(widget);
+    if (widget)
         reportGeometry();
 }
 
 void WebPluginContainerImpl::setPlugin(WebPlugin* plugin)
 {
     if (plugin != m_webPlugin) {
         m_element->resetInstance();
         m_webPlugin = plugin;
     }
 }
@@ skipping 248 matching lines @@
     if (Page* page = m_element->document().page()) {
         if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator()) {
             if (parent() && parent()->isFrameView())
                 scrollingCoordinator->frameViewLayoutUpdated(toFrameView(parent()));
         }
     }
 }
 
 WebPoint WebPluginContainerImpl::windowToLocalPoint(const WebPoint& point)
 {
-    ScrollView* view = parent();
+    ScrollView* view = toScrollView(parent());
     if (!view)
         return point;
     WebPoint windowPoint = view->windowToContents(point);
     return roundedIntPoint(m_element->renderer()->absoluteToLocal(LayoutPoint(windowPoint), UseTransforms));
 }
 
 WebPoint WebPluginContainerImpl::localToWindowPoint(const WebPoint& point)
 {
-    ScrollView* view = parent();
+    ScrollView* view = toScrollView(parent());
     if (!view)
         return point;
     IntPoint absolutePoint = roundedIntPoint(m_element->renderer()->localToAbsolute(LayoutPoint(point), UseTransforms));
     return view->contentsToWindow(absolutePoint);
 }
 
 void WebPluginContainerImpl::didReceiveResponse(const ResourceResponse& response)
 {
     // Make sure that the plugin receives window geometry before data, or else
     // plugins misbehave.
@@ skipping 313 matching lines @@
         currentPage->focusController().setFocusedElement(m_element, &containingFrame);
     else
         containingFrame.document()->setFocusedElement(m_element);
 }
 
 void WebPluginContainerImpl::calculateGeometry(const IntRect& frameRect,
                                                IntRect& windowRect,
                                                IntRect& clipRect,
                                                Vector<IntRect>& cutOutRects)
 {
-    windowRect = parent()->contentsToWindow(frameRect);
+    windowRect = toScrollView(parent())->contentsToWindow(frameRect);
 
     // Calculate a clip-rect so that we don't overlap the scrollbars, etc.
     clipRect = windowClipRect();
     clipRect.move(-windowRect.x(), -windowRect.y());
 
     getPluginOcclusions(m_element, this->parent(), frameRect, cutOutRects);
     // Convert to the plugin position.
     for (size_t i = 0; i < cutOutRects.size(); i++)
         cutOutRects[i].move(-frameRect.x(), -frameRect.y());
 }
@@ skipping 11 matching lines @@
         // Take our element and get the clip rect from the enclosing layer and
         // frame view.
         clipRect.intersect(
             m_element->document().view()->windowClipRectForFrameOwner(m_element, true));
     }
 
     return clipRect;
 }
 
 } // namespace WebKit