Issue 2693593002: keep null check on virtual field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2693593002: keep null check on virtual field (Closed)

Created:
3 years, 10 months ago by vsm

Modified:
3 years, 10 months ago

Reviewers:
Leaf

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

keep null check on virtual field We weren't correctly blocking the opt if the field was marked virtual R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/986a1c2775eee391335c90e28e958386bc9740dd

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -2 lines)			Patch
M	pkg/dev_compiler/lib/src/compiler/nullable_type_inference.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/dev_compiler/test-main.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/dev_compiler/tool/build_pkgs.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/language_strong/field_override_optimization_test.dart	View	1 chunk	+33 lines, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

vsm

3 years, 10 months ago (2017-02-11 00:00:21 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
986a1c2775eee391335c90e28e958386bc9740dd (presubmit successful).