webkitpy: Reworking test chunking for sharding.

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
index 6d1aee275bbe9cd456738fd60bd1c6a293fe0807..38d7593b7b63757b7e217315929f5e57e9886232 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
@@ -1174,6 +1174,11 @@ class TestExpectations(object):
             model.add_expectation_line(expectation_line)
         self._model.merge_model(model)
 
+    def remove_tests(self, tests_to_remove):
+        for test in self._expectations:
+            if test.name and test.name in tests_to_remove:

[qyearsley, 2017/02/13 21:49:00]

I guess that self._expectations may contain TestExpectationLine objects for
blank lines and comments, which is why we want to check name?

Also, I think `test.name` is almost always the same as `test.path`, but it
theoretically might be different; probably doesn't matter here.

[mithro, 2017/02/14 00:40:03]

I'm following the `add_extra_skipped_tests` code above.

+                self.remove_expectation_line(test)
+
     def add_expectations_from_bot(self):
         # FIXME: With mode 'very-flaky' and 'maybe-flaky', this will show the expectations entry in the flakiness
         # dashboard rows for each test to be whatever the bot thinks they should be. Is this a good thing?