Issue 269353003: Fix constructors for HLoadNamedField.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269353003: Fix constructors for HLoadNamedField. (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer

Modified:
6 years, 7 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix constructors for HLoadNamedField. Also try to determine an appropriate HType for tracked fields, instead of (incorrectly) using HType::NonPrimitive() everywhere. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21186

Patch Set 1 #

Total comments: 2

Patch Set 2 : Deuglify code #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -40 lines)			Patch
M	src/hydrogen.h	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View		4 chunks	+36 lines, -2 lines	0 comments	Download
M	src/hydrogen-check-elimination.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1	4 chunks	+48 lines, -29 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-load-elimination.cc	View	1	1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit (which might make sense or not :-) https://codereview.chromium.org/269353003/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): ...

6 years, 7 months ago (2014-05-07 07:31:52 UTC) #2

Benedikt Meurer

https://codereview.chromium.org/269353003/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/269353003/diff/1/src/hydrogen.cc#newcode5584 src/hydrogen.cc:5584: // Determine field HType from field HeapType. I don't ...

6 years, 7 months ago (2014-05-07 07:47:44 UTC) #3

Benedikt Meurer

6 years, 7 months ago (2014-05-07 08:41:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21186 (tree was closed).

Expand Messages | Collapse Messages