Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: ios/web/navigation/serializable_user_data_manager_impl.h

Issue 2693523003: Moved TabID implementation to SerializableUserData. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/navigation/serializable_user_data_manager_impl.h
diff --git a/ios/web/navigation/serializable_user_data_manager_impl.h b/ios/web/navigation/serializable_user_data_manager_impl.h
index 38fa1fb1c6402eef9bf6ef2602fc7d75256912b6..029e7f6edb6fd6efbfe31a14a150bceeef72b2b0 100644
--- a/ios/web/navigation/serializable_user_data_manager_impl.h
+++ b/ios/web/navigation/serializable_user_data_manager_impl.h
@@ -29,6 +29,16 @@ class SerializableUserDataImpl : public SerializableUserData {
// The dictionary passed on initialization. After calling Decode(), this will
// contain the data that is decoded from the NSCoder.
base::scoped_nsobject<NSDictionary> data_;
+ // Some values that were previously persisted directly in CRWSessionStorage
+ // are now serialized using SerializableUserData, and this dictionary is used
+ // to decode these values. The keys are the legacy encoding keys, and the
+ // values are their corresponding serializable user data keys.
+ base::scoped_nsobject<NSDictionary> legacy_key_conversions_;
Eugene But (OOO till 7-30) 2017/02/13 17:37:57 Do we need to set a milestone when we drop support
kkhorimoto 2017/02/13 23:41:18 Done.
+
+ // Decodes the values that were previously encoded using CRWSessionStorage's
+ // NSCoding implementation and returns an NSDictionary using the new
+ // serialization keys.
+ NSDictionary* GetDecodedLegacyValues(NSCoder* coder);
Eugene But (OOO till 7-30) 2017/02/13 17:37:57 Do you want to move method higher (before ivars)?
kkhorimoto 2017/02/13 23:41:18 Done.
};
class SerializableUserDataManagerImpl : public SerializableUserDataManager {

Powered by Google App Engine
This is Rietveld 408576698