Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 269343008: [SyncFS] Add a UMA to measure RTT in registration (Closed)

Created:
6 years, 7 months ago by peria
Modified:
6 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, kinuko+watch, jar (doing other things), nhiroki
Visibility:
Public.

Description

Add a UMA to measure RTT in registering "origin" path. BUG=None TEST=Manually R=asvitkine@chromium.org, tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269527

Patch Set 1 #

Total comments: 8

Patch Set 2 : Work for nits #

Patch Set 3 : Change summary description of UMA #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 1 3 chunks +14 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
peria
Tsuiki-san, PTL?
6 years, 7 months ago (2014-05-08 06:24:14 UTC) #1
tzik
https://codereview.chromium.org/269343008/diff/1/chrome/browser/sync_file_system/drive_backend/sync_engine.cc File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right): https://codereview.chromium.org/269343008/diff/1/chrome/browser/sync_file_system/drive_backend/sync_engine.cc#newcode536 chrome/browser/sync_file_system/drive_backend/sync_engine.cc:536: base::Time start_time, const ref? https://codereview.chromium.org/269343008/diff/1/chrome/browser/sync_file_system/drive_backend/sync_engine.cc#newcode539 chrome/browser/sync_file_system/drive_backend/sync_engine.cc:539: base::TimeDelta delta(base::Time::Now() - ...
6 years, 7 months ago (2014-05-08 06:39:09 UTC) #2
tzik
https://codereview.chromium.org/269343008/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/269343008/diff/1/tools/metrics/histograms/histograms.xml#newcode27873 tools/metrics/histograms/histograms.xml:27873: + Round trip time to register the root path ...
6 years, 7 months ago (2014-05-08 06:51:06 UTC) #3
peria
https://codereview.chromium.org/269343008/diff/1/chrome/browser/sync_file_system/drive_backend/sync_engine.cc File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right): https://codereview.chromium.org/269343008/diff/1/chrome/browser/sync_file_system/drive_backend/sync_engine.cc#newcode536 chrome/browser/sync_file_system/drive_backend/sync_engine.cc:536: base::Time start_time, On 2014/05/08 06:39:10, tzik wrote: > const ...
6 years, 7 months ago (2014-05-08 06:51:52 UTC) #4
peria
https://codereview.chromium.org/269343008/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/269343008/diff/1/tools/metrics/histograms/histograms.xml#newcode27873 tools/metrics/histograms/histograms.xml:27873: + Round trip time to register the root path ...
6 years, 7 months ago (2014-05-08 06:56:13 UTC) #5
tzik
Thanks! LGTM. Please request one of tools/metrics/OWNERS to review.
6 years, 7 months ago (2014-05-08 07:01:46 UTC) #6
peria
jar@ Could you take a look as an owner of tools/metrics?
6 years, 7 months ago (2014-05-08 07:08:04 UTC) #7
peria
On 2014/05/08 07:08:04, peria wrote: > jar@ > Could you take a look as an ...
6 years, 7 months ago (2014-05-09 05:33:00 UTC) #8
peria
Alexei Would you take a look?
6 years, 7 months ago (2014-05-09 06:19:39 UTC) #9
Alexei Svitkine (slow)
lgtm
6 years, 7 months ago (2014-05-09 13:14:48 UTC) #10
peria
The CQ bit was checked by peria@chromium.org
6 years, 7 months ago (2014-05-09 13:32:47 UTC) #11
peria
On 2014/05/09 13:14:48, Alexei Svitkine wrote: > lgtm Thank you! submitting.
6 years, 7 months ago (2014-05-09 13:34:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/269343008/30001
6 years, 7 months ago (2014-05-09 13:37:18 UTC) #13
tzik
6 years, 7 months ago (2014-05-10 04:47:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 manually as r269527.

Powered by Google App Engine
This is Rietveld 408576698