Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 269343003: Remove GenerateBooleanCheck() since we have a boolean map now. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm64/stub-cache-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "v8.h" 5 #include "v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "ic-inl.h" 9 #include "ic-inl.h"
10 #include "codegen.h" 10 #include "codegen.h"
(...skipping 1149 matching lines...) Expand 10 before | Expand all | Expand 10 after
1160 this->name(), interceptor_holder); 1160 this->name(), interceptor_holder);
1161 1161
1162 ExternalReference ref = 1162 ExternalReference ref =
1163 ExternalReference(IC_Utility(IC::kLoadPropertyWithInterceptorForLoad), 1163 ExternalReference(IC_Utility(IC::kLoadPropertyWithInterceptorForLoad),
1164 isolate()); 1164 isolate());
1165 __ TailCallExternalReference(ref, StubCache::kInterceptorArgsLength, 1); 1165 __ TailCallExternalReference(ref, StubCache::kInterceptorArgsLength, 1);
1166 } 1166 }
1167 } 1167 }
1168 1168
1169 1169
1170 void StubCompiler::GenerateBooleanCheck(Register object, Label* miss) {
1171 Label success;
1172 // Check that the object is a boolean.
1173 __ LoadRoot(ip, Heap::kTrueValueRootIndex);
1174 __ cmp(object, ip);
1175 __ b(eq, &success);
1176 __ LoadRoot(ip, Heap::kFalseValueRootIndex);
1177 __ cmp(object, ip);
1178 __ b(ne, miss);
1179 __ bind(&success);
1180 }
1181
1182
1183 Handle<Code> StoreStubCompiler::CompileStoreCallback( 1170 Handle<Code> StoreStubCompiler::CompileStoreCallback(
1184 Handle<JSObject> object, 1171 Handle<JSObject> object,
1185 Handle<JSObject> holder, 1172 Handle<JSObject> holder,
1186 Handle<Name> name, 1173 Handle<Name> name,
1187 Handle<ExecutableAccessorInfo> callback) { 1174 Handle<ExecutableAccessorInfo> callback) {
1188 Register holder_reg = HandlerFrontend( 1175 Register holder_reg = HandlerFrontend(
1189 IC::CurrentTypeOf(object, isolate()), receiver(), holder, name); 1176 IC::CurrentTypeOf(object, isolate()), receiver(), holder, name);
1190 1177
1191 // Stub never generated for non-global objects that require access checks. 1178 // Stub never generated for non-global objects that require access checks.
1192 ASSERT(holder->IsJSGlobalProxy() || !holder->IsAccessCheckNeeded()); 1179 ASSERT(holder->IsJSGlobalProxy() || !holder->IsAccessCheckNeeded());
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
1535 // ----------------------------------- 1522 // -----------------------------------
1536 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1523 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1537 } 1524 }
1538 1525
1539 1526
1540 #undef __ 1527 #undef __
1541 1528
1542 } } // namespace v8::internal 1529 } } // namespace v8::internal
1543 1530
1544 #endif // V8_TARGET_ARCH_ARM 1531 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/stub-cache-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698