Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(24)

Issue 2693423007: Introduce GN config files. (Closed)

Created:
3 years, 8 months ago by veranika
Modified:
3 years, 8 months ago
Reviewers:
ftirelo
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce GN config files. Also pulls necessary Chromium dependencies. Chromium will be not pulled from HEAD due to possibility of breaking changes introduced in the Chromium tree. DEPS will be rolled manually. BUG= R=ftirelo@chromium.org Committed: https://chromium.googlesource.com/chromium/pipa/+/6699264e6a6f79ad7acf90085ebc2d22722cf704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -6 lines) Patch
M .gitignore View 1 chunk +7 lines, -1 line 0 comments Download
A .gn View 1 chunk +13 lines, -0 lines 0 comments Download
A BUILD.gn View 1 chunk +16 lines, -0 lines 0 comments Download
M DEPS View 2 chunks +11 lines, -1 line 0 comments Download
M GITDEPS View 2 chunks +25 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
veranika
3 years, 8 months ago (2017-02-17 19:31:33 UTC) #3
ftirelo
lgtm Cool!
3 years, 8 months ago (2017-02-17 19:41:39 UTC) #4
veranika
3 years, 8 months ago (2017-02-17 19:52:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6699264e6a6f79ad7acf90085ebc2d22722cf704 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698