Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: pkg/compiler/lib/src/ssa/builder_kernel.dart

Issue 2693423003: Clean up deferred checks in Kernel. (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder_kernel.dart
diff --git a/pkg/compiler/lib/src/ssa/builder_kernel.dart b/pkg/compiler/lib/src/ssa/builder_kernel.dart
index 81e533eb925593ed35df18005c2eca938e440567..87e8380bda2d3e0d3d0d7b2a074b566b8068c002 100644
--- a/pkg/compiler/lib/src/ssa/builder_kernel.dart
+++ b/pkg/compiler/lib/src/ssa/builder_kernel.dart
@@ -596,11 +596,9 @@ class KernelSsaBuilder extends ir.Visitor with GraphBuilder {
void visitCheckLibraryIsLoaded(ir.CheckLibraryIsLoaded checkLoad) {
HInstruction prefixConstant = graph.addConstantString(
new DartString.literal(checkLoad.import.name), closedWorld);
+ var prefixElement = astAdapter.getElement(checkLoad.import);
HInstruction uriConstant = graph.addConstantString(
- new DartString.literal(compiler.deferredLoadTask.getImportDeferName(
- // TODO(efortuna): Source information.
- null,
- astAdapter.getElement(checkLoad.import))),
+ new DartString.literal(prefixElement.deferredImport.uri.toString()),
sra1 2017/02/15 23:55:31 Is this the short form?
Emily Fortuna 2017/02/16 02:21:56 yup. this is the short form.
closedWorld);
_pushStaticInvocation(astAdapter.checkDeferredIsLoaded,
[prefixConstant, uriConstant], astAdapter.checkDeferredIsLoadedType);

Powered by Google App Engine
This is Rietveld 408576698