Clean up deferred checks in Kernel.

Add deferred library loaded checks in a few more places in Kernel.

BUG=
R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/d9e9f4c9209e4caeeaa24c5a0db3bc1ed3a62a56

[Emily Fortuna, 2017-02-15 22:05:35]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2017-02-15 22:06:29]

Description was changed from

==========
Clean up deferred checks in Kernel.

BUG=
==========

to

==========
Add deferred library loaded checks in a few more places in Kernel.

BUG=
==========

[Emily Fortuna, 2017-02-15 22:06:29]

efortuna@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-02-15 23:55:31]

lgtm

https://codereview.chromium.org/2693423003/diff/20001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/kernel_visitor.dart (right):

https://codereview.chromium.org/2693423003/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/kernel_visitor.dart:2717: // number of expressions
that access a deferred member.
consider:

  prefix1.foo(prefix2.a, prefix3.b)

does this check the prefixes in the right order?

https://codereview.chromium.org/2693423003/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2693423003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:601: new
DartString.literal(prefixElement.deferredImport.uri.toString()),
Is this the short form?

[Emily Fortuna, 2017-02-16 02:21:57]

https://codereview.chromium.org/2693423003/diff/20001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/kernel_visitor.dart (right):

https://codereview.chromium.org/2693423003/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/kernel_visitor.dart:2717: // number of expressions
that access a deferred member.
On 2017/02/15 23:55:31, sra1 wrote:
> consider:
> 
>   prefix1.foo(prefix2.a, prefix3.b)
> 
> does this check the prefixes in the right order?

yes.

https://codereview.chromium.org/2693423003/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2693423003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:601: new
DartString.literal(prefixElement.deferredImport.uri.toString()),
On 2017/02/15 23:55:31, sra1 wrote:
> Is this the short form?

yup. this is the short form.

[Emily Fortuna, 2017-02-16 02:22:06]

Patchset #2 (id:40001) has been deleted

[Emily Fortuna, 2017-02-16 02:23:24]

Description was changed from

==========
Add deferred library loaded checks in a few more places in Kernel.

BUG=
==========

to

==========
Add deferred library loaded checks in a few more places in Kernel.

BUG=
R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d9e9f4c9209e4caeeaa24c5a0db3bc1ed3a62a56
==========

[Emily Fortuna, 2017-02-16 02:23:25]

Committed patchset #2 (id:60001) manually as
d9e9f4c9209e4caeeaa24c5a0db3bc1ed3a62a56 (presubmit successful).