Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: third_party/WebKit/Source/core/dom/ScriptLoader.h

Issue 2693423002: Do not re-initialize PendingScript in HTMLParserScriptRunner (Closed)
Patch Set: Reflect comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ScriptLoader.h
diff --git a/third_party/WebKit/Source/core/dom/ScriptLoader.h b/third_party/WebKit/Source/core/dom/ScriptLoader.h
index d483642b99a1eb5a42b72d952384d2c387adde45..295c12c9250ccdb07d50c8265da4b9d5066f4d3d 100644
--- a/third_party/WebKit/Source/core/dom/ScriptLoader.h
+++ b/third_party/WebKit/Source/core/dom/ScriptLoader.h
@@ -107,9 +107,6 @@ class CORE_EXPORT ScriptLoader : public GarbageCollectedFinalized<ScriptLoader>,
return m_pendingScript && m_pendingScript->errorOccurred();
}
- // Clears the connection to the PendingScript (and Element and Resource).
- void detach();
-
bool wasCreatedDuringDocumentWrite() { return m_createdDuringDocumentWrite; }
bool disallowedFetchForDocWrittenScript() {
@@ -136,6 +133,9 @@ class CORE_EXPORT ScriptLoader : public GarbageCollectedFinalized<ScriptLoader>,
ScriptLoaderClient* client() const;
+ // Clears the connection to the PendingScript.
+ void detachPendingScript();
+
// PendingScriptClient
void pendingScriptFinished(PendingScript*) override;

Powered by Google App Engine
This is Rietveld 408576698