Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

Issue 2693423002: Do not re-initialize PendingScript in HTMLParserScriptRunner (Closed)
Patch Set: fix test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ScriptLoader.cpp
diff --git a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
index 59c18165977be6808061e6b8025c7f35ef0df0c6..25732d8e9cb9c6d5b1fa0eedba9a10d0f9797380 100644
--- a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
+++ b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
@@ -818,6 +818,7 @@ void ScriptLoader::execute() {
bool errorOccurred = false;
ScriptSourceCode source = m_pendingScript->getSource(KURL(), errorOccurred);
m_pendingScript->dispose();
sof 2017/02/16 08:15:15 Call detach() instead? Actually, I think we should
hiroshige 2017/02/17 23:15:15 Done.
+ m_pendingScript = nullptr;
if (errorOccurred) {
dispatchErrorEvent();
} else if (!m_resource->wasCanceled()) {

Powered by Google App Engine
This is Rietveld 408576698