Do not re-initialize PendingScript in HTMLParserScriptRunner

third_party/WebKit/Source/core/dom/ScriptLoader.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2008 Nikolas Zimmermann <zimmermann@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 124 matching lines @@
 }
 
 void ScriptLoader::handleAsyncAttribute() {
   // https://html.spec.whatwg.org/#non-blocking
   // "In addition, whenever a script element whose "non-blocking" flag is set
   //  has an async content attribute added, the element's "non-blocking" flag
   //  must be unset."
   m_nonBlocking = false;
 }
 
-void ScriptLoader::detach() {
+void ScriptLoader::detachPendingScript() {
   if (!m_pendingScript)
     return;
   m_pendingScript->dispose();
   m_pendingScript = nullptr;
 }
 
 static bool isLegacySupportedJavaScriptLanguage(const String& language) {
   // Mozilla 1.8 accepts javascript1.0 - javascript1.7, but WinIE 7 accepts only
   // javascript1.1 - javascript1.3.
   // Mozilla 1.8 and WinIE 7 both accept javascript and livescript.
@@ skipping 654 matching lines @@
   //     if it was incremented in the earlier step."
   // Implemented as the scope out of IgnoreDestructiveWriteCountIncrementer.
 }
 
 void ScriptLoader::execute() {
   DCHECK(!m_willBeParserExecuted);
   DCHECK(m_asyncExecType != ScriptRunner::None);
   DCHECK(m_pendingScript->resource());
   bool errorOccurred = false;
   ScriptSourceCode source = m_pendingScript->getSource(KURL(), errorOccurred);
-  m_pendingScript->dispose();
+  detachPendingScript();
   if (errorOccurred) {
     dispatchErrorEvent();
   } else if (!m_resource->wasCanceled()) {
     if (executeScript(source))
       dispatchLoadEvent();
     else
       dispatchErrorEvent();
   }
   m_resource = nullptr;
 }
@@ skipping 10 matching lines @@
       DocumentWriteIntervention::FetchDocWrittenScriptDeferIdle) {
     memoryCache()->remove(m_pendingScript->resource());
     m_pendingScript->stopWatchingForLoad();
     return;
   }
 
   DCHECK(m_asyncExecType != ScriptRunner::None);
 
   Document* contextDocument = m_element->document().contextDocument();
   if (!contextDocument) {
-    detach();
+    detachPendingScript();
     return;
   }
 
   DCHECK_EQ(pendingScript->resource(), m_resource);
 
   if (m_resource->errorOccurred()) {
     contextDocument->scriptRunner()->notifyScriptLoadError(this,
                                                            m_asyncExecType);
-    detach();
+    detachPendingScript();
     dispatchErrorEvent();
     return;
   }
   contextDocument->scriptRunner()->notifyScriptReady(this, m_asyncExecType);
   m_pendingScript->stopWatchingForLoad();
 }
 
 bool ScriptLoader::ignoresLoadRequest() const {
   return m_alreadyStarted || m_isExternalScript || m_parserInserted ||
          !element() || !element()->isConnected();
@@ skipping 46 matching lines @@
   if (isHTMLScriptLoader(element))
     return toHTMLScriptElement(element)->loader();
 
   if (isSVGScriptLoader(element))
     return toSVGScriptElement(element)->loader();
 
   return 0;
 }
 
 }  // namespace blink