Do not re-initialize PendingScript in HTMLParserScriptRunner

third_party/WebKit/Source/core/dom/PendingScript.h

 /*
  * Copyright (C) 2010 Google, Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 52 matching lines @@
 // guarantee that the data buffer will not be purged.
 class CORE_EXPORT PendingScript final
     : public GarbageCollectedFinalized<PendingScript>,
       public ResourceOwner<ScriptResource>,
       public MemoryCoordinatorClient {
   USING_GARBAGE_COLLECTED_MIXIN(PendingScript);
   USING_PRE_FINALIZER(PendingScript, dispose);
   WTF_MAKE_NONCOPYABLE(PendingScript);
 
  public:
+  // For script from an external file.
   static PendingScript* create(Element*, ScriptResource*);
+  // For inline script.
+  static PendingScript* create(Element*, const TextPosition&);
+
+  static PendingScript* createForTesting(ScriptResource*);
+
   ~PendingScript() override;
 
   TextPosition startingPosition() const { return m_startingPosition; }
-  void setStartingPosition(const TextPosition& position) {
-    m_startingPosition = position;
-  }
   void markParserBlockingLoadStartTime();
   // Returns the time the load of this script started blocking the parser, or
   // zero if this script hasn't yet blocked the parser, in
   // monotonicallyIncreasingTime.
   double parserBlockingLoadStartTime() const {
     return m_parserBlockingLoadStartTime;
   }
 
   void watchForLoad(PendingScriptClient*);
   void stopWatchingForLoad();
 
-  Element* element() const { return m_element.get(); }
-  void setElement(Element*);
-
-  void setScriptResource(ScriptResource*);
+  Element* element() const;
 
   DECLARE_TRACE();
 
   ScriptSourceCode getSource(const KURL& documentURL,
                              bool& errorOccurred) const;
 
   void setStreamer(ScriptStreamer*);
   void streamingFinished();
 
   bool isReady() const;
   bool errorOccurred() const;
 
   void dispose();
 
  private:
-  PendingScript(Element*, ScriptResource*);
+  PendingScript(Element*,
+                ScriptResource*,
+                const TextPosition&,
+                bool isForTesting = false);
   PendingScript() = delete;
 
   // ScriptResourceClient
   void notifyFinished(Resource*) override;
   String debugName() const override { return "PendingScript"; }
   void notifyAppendData(ScriptResource*) override;
 
   // MemoryCoordinatorClient
   void onPurgeMemory() override;
 
   bool m_watchingForLoad;
+
+  // |m_element| must points to the corresponding ScriptLoader's element and
+  // thus must be non-null before dispose() is called.
   Member<Element> m_element;
+
   TextPosition m_startingPosition;  // Only used for inline script tags.
   bool m_integrityFailure;
   double m_parserBlockingLoadStartTime;
 
   Member<ScriptStreamer> m_streamer;
   Member<PendingScriptClient> m_client;
+
+  // In unit tests |m_element| can be null.

[sof, 2017/02/16 08:15:15]

nit: null => false

[hiroshige, 2017/02/17 23:15:15]

|m_element| is Member<Element> so it is |null|.
Rephrased.

+  // This flag is used to skip non-null checks of |m_element| in tests.
+  const bool m_isForTesting;
 };
 
 }  // namespace blink
 
 #endif  // PendingScript_h