Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: extensions/browser/policy_check.h

Issue 2693373003: PreloadCheck class for extension pre-install checks (Closed)
Patch Set: review ready Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/policy_check.h
diff --git a/extensions/browser/policy_check.h b/extensions/browser/policy_check.h
new file mode 100644
index 0000000000000000000000000000000000000000..4cdf1bca1958b4d2afde3489b37193ee2cf777bf
--- /dev/null
+++ b/extensions/browser/policy_check.h
@@ -0,0 +1,40 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_BROWSER_POLICY_CHECK_H_
+#define EXTENSIONS_BROWSER_POLICY_CHECK_H_
+
+#include "base/macros.h"
+#include "base/strings/string16.h"
+#include "extensions/browser/preload_check.h"
+
+namespace content {
+class BrowserContext;
+}
+
+namespace extensions {
+
+class Extension;
+
+// Checks whether loading this extension is disabled by policy. Synchronously
+// calls the callback with the result.
+class PolicyCheck : public PreloadCheck {
+ public:
+ PolicyCheck(content::BrowserContext* context, const Extension* extension);
+ ~PolicyCheck() override;
+
+ // PreloadCheck:
+ void Start(ResultCallback callback) override;
+ bool GetErrorMessage(base::string16* error) const override;
+
+ private:
+ content::BrowserContext* context_;
+ mutable base::string16 error_;
Devlin 2017/03/08 03:01:45 why not just un-constify GetErrorMessage?
michaelpg 2017/03/09 01:53:30 GetErrorMessage shouldn't modify logical state. Bu
+
+ DISALLOW_COPY_AND_ASSIGN(PolicyCheck);
+};
+
+} // namespace extensions
+
+#endif // EXTENSIONS_BROWSER_POLICY_CHECK_H_

Powered by Google App Engine
This is Rietveld 408576698