Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4831)

Unified Diff: chrome/browser/extensions/blacklist_check_unittest.cc

Issue 2693373003: PreloadCheck class for extension pre-install checks (Closed)
Patch Set: review ready Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/blacklist_check_unittest.cc
diff --git a/chrome/browser/extensions/blacklist_check_unittest.cc b/chrome/browser/extensions/blacklist_check_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8f243c5332f951f28c45b9458fbdc1fa6363c477
--- /dev/null
+++ b/chrome/browser/extensions/blacklist_check_unittest.cc
@@ -0,0 +1,99 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/blacklist_check.h"
+#include "base/bind.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "chrome/browser/extensions/blacklist.h"
+#include "chrome/browser/extensions/test_blacklist.h"
+#include "chrome/browser/extensions/test_extension_prefs.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "extensions/browser/extension_prefs.h"
+#include "extensions/browser/preload_check.h"
+#include "extensions/browser/preload_check_test_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+namespace {
+
+class BlacklistCheckTest : public testing::Test {
+ public:
+ BlacklistCheckTest()
+ : test_prefs_(base::ThreadTaskRunnerHandle::Get()),
+ blacklist_(test_prefs_.prefs()) {}
+
+ protected:
+ void SetUp() override {
+ test_blacklist_.Attach(&blacklist_);
+ extension_ = test_prefs_.AddExtension("foo");
+ }
+
+ void SetBlacklistState(BlacklistState state) {
+ test_blacklist_.SetBlacklistState(extension_->id(), state, true);
+ }
+
+ void StartBlacklistCheck(PreloadCheckObserver* observer) {
+ blacklist_check_ =
+ base::MakeUnique<BlacklistCheck>(&blacklist_, extension_.get());
+ blacklist_check_->Start(base::Bind(&PreloadCheckObserver::OnCheckComplete,
+ base::Unretained(observer)));
+ }
+
+ void StopBlacklistCheck() { blacklist_check_.reset(); }
+
+ BlacklistCheck* blacklist_check() { return blacklist_check_.get(); }
+
+ private:
+ content::TestBrowserThreadBundle browser_thread_bundle_;
+ TestExtensionPrefs test_prefs_;
+ Blacklist blacklist_;
+ TestBlacklist test_blacklist_;
+ scoped_refptr<Extension> extension_;
+ std::unique_ptr<BlacklistCheck> blacklist_check_;
+};
+
+} // namespace
+
+// Tests that the blacklist check identifies a blacklisted extension.
+TEST_F(BlacklistCheckTest, BlacklistedMalware) {
+ SetBlacklistState(BLACKLISTED_MALWARE);
+
+ PreloadCheckObserver observer;
+ StartBlacklistCheck(&observer);
+ observer.Wait();
+
+ EXPECT_EQ(1, observer.call_count());
+ EXPECT_EQ(1u, observer.errors().size());
+ EXPECT_EQ(1u, observer.errors().count(PreloadCheck::BLACKLISTED_ID));
+ base::string16 message;
+ EXPECT_FALSE(blacklist_check()->GetErrorMessage(&message));
+}
+
+// Tests that the blacklist check ignores a non-blacklisted extension.
+TEST_F(BlacklistCheckTest, Pass) {
+ SetBlacklistState(NOT_BLACKLISTED);
+
+ PreloadCheckObserver observer;
+ StartBlacklistCheck(&observer);
+ observer.Wait();
+
+ EXPECT_EQ(1, observer.call_count());
+ EXPECT_EQ(0u, observer.errors().size());
+ base::string16 message;
+ EXPECT_FALSE(blacklist_check()->GetErrorMessage(&message));
+}
+
+// Tests that destroying the check after starting it does not cause errors.
+TEST_F(BlacklistCheckTest, StopCheck) {
+ SetBlacklistState(BLACKLISTED_MALWARE);
+
+ PreloadCheckObserver observer;
+ StartBlacklistCheck(&observer);
+ StopBlacklistCheck();
+ observer.Wait();
+
+ EXPECT_EQ(0, observer.call_count());
+}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698