Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: extensions/browser/preload_check.h

Issue 2693373003: PreloadCheck class for extension pre-install checks (Closed)
Patch Set: devlin Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/preload_check.h
diff --git a/extensions/browser/preload_check.h b/extensions/browser/preload_check.h
new file mode 100644
index 0000000000000000000000000000000000000000..3db9a374a3203843a5e2e430457301695f24636c
--- /dev/null
+++ b/extensions/browser/preload_check.h
@@ -0,0 +1,57 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_BROWSER_PRELOAD_CHECK_H_
+#define EXTENSIONS_BROWSER_PRELOAD_CHECK_H_
+
+#include <memory>
Devlin 2017/03/16 01:42:44 Needed?
michaelpg 2017/03/17 02:34:26 Done.
+#include <set>
+#include <utility>
Devlin 2017/03/16 01:42:44 needed?
michaelpg 2017/03/17 02:34:26 Done.
+
+#include "base/callback.h"
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "base/strings/string16.h"
+#include "extensions/common/extension.h"
Devlin 2017/03/16 01:42:44 nit: forward declaration instead of this include
michaelpg 2017/03/17 02:34:26 Done.
+
+namespace extensions {
+
+// Encapsulates a possibly asynchronous operation to verify whether a
+// precondition holds for loading the given extension.
+class PreloadCheck {
+ public:
+ // These enumerators should only be referred to by name, so it is safe to
+ // insert or remove values as necessary.
+ enum Error {
+ NONE,
+ BLACKLISTED_ID,
+ BLACKLISTED_UNKNOWN,
+ DISALLOWED_BY_POLICY,
+ };
+
+ using Errors = std::set<Error>;
+ using ResultCallback = base::OnceCallback<void(Errors)>;
+
+ explicit PreloadCheck(scoped_refptr<const Extension> extension);
+ virtual ~PreloadCheck();
+
+ // This function must be called on the UI thread. The callback also occurs on
+ // the UI thread.
+ virtual void Start(ResultCallback callback) = 0;
+
+ // Subclasses may provide an error message.
+ virtual base::string16 GetErrorMessage() const;
+
+ const Extension* extension() { return extension_.get(); }
+
+ private:
+ // The extension to check.
+ scoped_refptr<const Extension> extension_;
+
+ DISALLOW_COPY_AND_ASSIGN(PreloadCheck);
+};
+
+} // namespace extensions
+
+#endif // EXTENSIONS_BROWSER_PRELOAD_CHECK_H_

Powered by Google App Engine
This is Rietveld 408576698