extensions/browser/preload_check_test_util.cc - Issue 2693373003: PreloadCheck class for extension pre-install checks

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/preload_check_test_util.cc

Issue 2693373003: PreloadCheck class for extension pre-install checks (Closed)

Patch Set: review ready Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "extensions/browser/preload_check_test_util.h"

	6

	7 namespace extensions {

	8

	9 PreloadCheckObserver::PreloadCheckObserver() : call_count_(0) {}

	10 PreloadCheckObserver::~PreloadCheckObserver() {}

	11

	12 void PreloadCheckObserver::OnCheckComplete(PreloadCheck::Errors errors) {
	Devlin 2017/03/08 03:01:48 ASSERT_TRUE(errors_.empty())? ASSERT_TRUE(errors_.empty())? michaelpg 2017/03/09 01:53:30 CHECK? (I hesitate to #include gtest.h here.) Show quoted text On 2017/03/08 03:01:48, Devlin wrote: > ASSERT_TRUE(errors_.empty())? CHECK? (I hesitate to #include gtest.h here.)
	13 errors_ = errors;

	14 ++call_count_;

	15 }

	16

	17 } // namespace extensions

OLD	NEW