Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: chrome/browser/extensions/blacklist_check_unittest.cc

Issue 2693373003: PreloadCheck class for extension pre-install checks (Closed)
Patch Set: review ready Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/extensions/blacklist_check.h"
6 #include "base/bind.h"
7 #include "base/threading/thread_task_runner_handle.h"
8 #include "chrome/browser/extensions/blacklist.h"
9 #include "chrome/browser/extensions/test_blacklist.h"
10 #include "chrome/browser/extensions/test_extension_prefs.h"
11 #include "content/public/test/test_browser_thread_bundle.h"
12 #include "extensions/browser/extension_prefs.h"
13 #include "extensions/browser/preload_check.h"
14 #include "extensions/browser/preload_check_test_util.h"
15 #include "testing/gtest/include/gtest/gtest.h"
16
17 namespace extensions {
18 namespace {
19
20 class BlacklistCheckTest : public testing::Test {
21 public:
22 BlacklistCheckTest()
23 : test_prefs_(base::ThreadTaskRunnerHandle::Get()),
24 blacklist_(test_prefs_.prefs()) {}
25
26 protected:
27 void SetUp() override {
28 test_blacklist_.Attach(&blacklist_);
29 extension_ = test_prefs_.AddExtension("foo");
30 }
31
32 void SetBlacklistState(BlacklistState state) {
33 test_blacklist_.SetBlacklistState(extension_->id(), state, true);
34 }
35
36 void StartBlacklistCheck(PreloadCheckObserver* observer) {
37 blacklist_check_ =
38 base::MakeUnique<BlacklistCheck>(&blacklist_, extension_.get());
39 blacklist_check_->Start(base::Bind(&PreloadCheckObserver::OnCheckComplete,
40 base::Unretained(observer)));
41 }
42
43 void StopBlacklistCheck() { blacklist_check_.reset(); }
44
45 BlacklistCheck* blacklist_check() { return blacklist_check_.get(); }
46
47 private:
48 content::TestBrowserThreadBundle browser_thread_bundle_;
49 TestExtensionPrefs test_prefs_;
50 Blacklist blacklist_;
51 TestBlacklist test_blacklist_;
52 scoped_refptr<Extension> extension_;
53 std::unique_ptr<BlacklistCheck> blacklist_check_;
54 };
55
56 } // namespace
57
58 // Tests that the blacklist check identifies a blacklisted extension.
59 TEST_F(BlacklistCheckTest, BlacklistedMalware) {
60 SetBlacklistState(BLACKLISTED_MALWARE);
61
62 PreloadCheckObserver observer;
63 StartBlacklistCheck(&observer);
64 observer.Wait();
65
66 EXPECT_EQ(1, observer.call_count());
67 EXPECT_EQ(1u, observer.errors().size());
68 EXPECT_EQ(1u, observer.errors().count(PreloadCheck::BLACKLISTED_ID));
69 base::string16 message;
70 EXPECT_FALSE(blacklist_check()->GetErrorMessage(&message));
71 }
72
73 // Tests that the blacklist check ignores a non-blacklisted extension.
74 TEST_F(BlacklistCheckTest, Pass) {
75 SetBlacklistState(NOT_BLACKLISTED);
76
77 PreloadCheckObserver observer;
78 StartBlacklistCheck(&observer);
79 observer.Wait();
80
81 EXPECT_EQ(1, observer.call_count());
82 EXPECT_EQ(0u, observer.errors().size());
83 base::string16 message;
84 EXPECT_FALSE(blacklist_check()->GetErrorMessage(&message));
85 }
86
87 // Tests that destroying the check after starting it does not cause errors.
88 TEST_F(BlacklistCheckTest, StopCheck) {
89 SetBlacklistState(BLACKLISTED_MALWARE);
90
91 PreloadCheckObserver observer;
92 StartBlacklistCheck(&observer);
93 StopBlacklistCheck();
94 observer.Wait();
95
96 EXPECT_EQ(0, observer.call_count());
97 }
98
99 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698