PreloadCheck class for extension pre-install checks

extensions/browser/policy_check_unittest.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/browser/policy_check.h"
+
+#include <vector>
+
+#include "base/memory/ref_counted.h"
+#include "base/strings/string16.h"
+#include "base/strings/utf_string_conversions.h"
+#include "content/public/test/test_browser_context.h"
+#include "extensions/browser/extension_system.h"
+#include "extensions/browser/extensions_test.h"
+#include "extensions/browser/management_policy.h"
+#include "extensions/browser/mock_extension_system.h"
+#include "extensions/browser/preload_check.h"
+#include "extensions/browser/preload_check_test_util.h"
+#include "extensions/browser/test_extensions_browser_client.h"
+#include "extensions/common/constants.h"
+#include "extensions/common/extension.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+namespace {
+
+const base::string16 kDummyPolicyError =

[Devlin, 2017/03/16 01:42:44]

can't have static non-POD.  Just go ahead and inline this in UserMayLoad.

[michaelpg, 2017/03/17 02:34:26]

Inlined the string conversions.

+    base::ASCIIToUTF16("Cannot install extension");
+
+class ManagementPolicyMock : public ManagementPolicy::Provider {
+ public:
+  ManagementPolicyMock(const Extension* extension, bool may_load)
+      : extension_(extension), may_load_(may_load) {}
+
+  std::string GetDebugPolicyProviderName() const override {
+    return "ManagementPolicyMock";
+  }
+
+  bool UserMayLoad(const Extension* extension,
+                   base::string16* error) const override {
+    EXPECT_EQ(extension_, extension);
+    if (!may_load_)
+      *error = kDummyPolicyError;
+    return may_load_;
+  }
+
+ private:
+  const Extension* extension_;
+  bool may_load_;
+};
+
+class TestExtensionSystem : public MockExtensionSystem {
+ public:
+  explicit TestExtensionSystem(content::BrowserContext* context)
+      : MockExtensionSystem(context) {}
+  ~TestExtensionSystem() override {}
+
+  ManagementPolicy* management_policy() override { return &management_policy_; }
+
+ private:
+  ManagementPolicy management_policy_;
+};
+
+}  // namespace
+
+class PolicyCheckTest : public ExtensionsTest {
+ public:
+  PolicyCheckTest() {
+    // Replace the MockExtensionSystemFactory set by ExtensionsTest.
+    extensions_browser_client()->set_extension_system_factory(&factory_);
+  }
+
+  ~PolicyCheckTest() override {}
+
+  void SetUp() override {
+    ExtensionsTest::SetUp();
+
+    base::DictionaryValue manifest_dict;
+    manifest_dict.SetString("name", "dummy name");
+    manifest_dict.SetString("version", "1");
+    std::string error;
+
+    extension_ = Extension::Create(base::FilePath(), Manifest::UNPACKED,
+                                   manifest_dict, Extension::NO_FLAGS, &error);
+    EXPECT_TRUE(extension_.get()) << error;
+  }
+
+ protected:
+  MockExtensionSystemFactory<TestExtensionSystem> factory_;
+  scoped_refptr<Extension> extension_;
+  PreloadCheckRunner runner_;
+};
+
+// Test a valid extension.
+TEST_F(PolicyCheckTest, PolicySuccess) {
+  ManagementPolicyMock policy(extension_.get(), true);
+  ExtensionSystem::Get(browser_context())
+      ->management_policy()
+      ->RegisterProvider(&policy);
+
+  PolicyCheck policy_check(browser_context(), extension_);
+  policy_check.Start(runner_.GetCallback());
+  EXPECT_TRUE(runner_.called());
+  EXPECT_EQ(0u, runner_.errors().size());
+  EXPECT_TRUE(policy_check.GetErrorMessage().empty());
+}
+
+// Test an invalid extension.

[Devlin, 2017/03/16 01:42:44]

s/invalid/disallowed (and analogous for valid on line 96)

[michaelpg, 2017/03/17 02:34:26]

Done.

+TEST_F(PolicyCheckTest, PolicyFailure) {
+  ManagementPolicyMock policy(extension_.get(), false);
+  ExtensionSystem::Get(browser_context())
+      ->management_policy()
+      ->RegisterProvider(&policy);
+
+  PolicyCheck policy_check(browser_context(), extension_);
+  policy_check.Start(runner_.GetCallback());
+  EXPECT_TRUE(runner_.called());
+  EXPECT_THAT(runner_.errors(), testing::UnorderedElementsAre(
+                                    PreloadCheck::DISALLOWED_BY_POLICY));
+  EXPECT_EQ(kDummyPolicyError, policy_check.GetErrorMessage());
+}
+
+}  // namespace extensions