PreloadCheck class for extension pre-install checks

chrome/browser/extensions/blacklist_check_unittest.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/blacklist_check.h"

[Devlin, 2017/03/14 01:44:34]

grr... git cl format's include reordering isn't quite right, I think.  \n here.

[michaelpg, 2017/03/14 21:58:29]

Done.

+#include "base/bind.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "chrome/browser/extensions/blacklist.h"
+#include "chrome/browser/extensions/test_blacklist.h"
+#include "chrome/browser/extensions/test_extension_prefs.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "extensions/browser/extension_prefs.h"
+#include "extensions/browser/preload_check.h"
+#include "extensions/browser/preload_check_test_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+namespace {
+
+class BlacklistCheckTest : public testing::Test {
+ public:
+  BlacklistCheckTest()
+      : test_prefs_(base::ThreadTaskRunnerHandle::Get()),
+        blacklist_(test_prefs_.prefs()) {}
+
+ protected:
+  void SetUp() override {
+    test_blacklist_.Attach(&blacklist_);
+    extension_ = test_prefs_.AddExtension("foo");
+  }
+
+  void SetBlacklistState(BlacklistState state) {
+    test_blacklist_.SetBlacklistState(extension_->id(), state, true);

[Devlin, 2017/03/14 01:44:34]

doc anonymous bool

[michaelpg, 2017/03/14 21:58:29]

Done.

+  }
+
+  void StartBlacklistCheck(PreloadCheckObserver* observer) {
+    blacklist_check_ =
+        base::MakeUnique<BlacklistCheck>(&blacklist_, extension_);
+    blacklist_check_->Start(base::Bind(&PreloadCheckObserver::OnCheckComplete,
+                                       base::Unretained(observer)));
+  }
+
+  void StopBlacklistCheck() { blacklist_check_.reset(); }

[Devlin, 2017/03/14 01:44:34]

nit: maybe s/Stop/Reset||Destroy?  "Stop" seems so peaceful.

[michaelpg, 2017/03/14 21:58:29]

removed, but renamed test s/Stop/Reset

+
+  BlacklistCheck* blacklist_check() { return blacklist_check_.get(); }
+
+ private:
+  content::TestBrowserThreadBundle browser_thread_bundle_;
+  TestExtensionPrefs test_prefs_;
+  Blacklist blacklist_;
+  TestBlacklist test_blacklist_;
+  scoped_refptr<Extension> extension_;
+  std::unique_ptr<BlacklistCheck> blacklist_check_;
+};
+
+}  // namespace
+
+// Tests that the blacklist check identifies a blacklisted extension.
+TEST_F(BlacklistCheckTest, BlacklistedMalware) {
+  SetBlacklistState(BLACKLISTED_MALWARE);
+
+  PreloadCheckObserver observer;
+  StartBlacklistCheck(&observer);
+  observer.Wait();
+
+  EXPECT_TRUE(observer.called());
+  EXPECT_EQ(1u, observer.errors().size());

[Devlin, 2017/03/14 01:44:34]

You could substitute these with:
EXPECT_THAT(observer.errors(),
testing::UnorderedElementsAre(PreloadCheck::BLACKLISTED_ID));

so that you don't have to check size and contents (and it prints out slightly
more useful error messages).

[michaelpg, 2017/03/14 21:58:29]

sweet!

+  EXPECT_EQ(1u, observer.errors().count(PreloadCheck::BLACKLISTED_ID));
+  EXPECT_TRUE(blacklist_check()->GetErrorMessage().empty());
+}
+
+// Tests that the blacklist check ignores a non-blacklisted extension.
+TEST_F(BlacklistCheckTest, Pass) {
+  SetBlacklistState(NOT_BLACKLISTED);
+
+  PreloadCheckObserver observer;
+  StartBlacklistCheck(&observer);
+  observer.Wait();
+
+  EXPECT_TRUE(observer.called());
+  EXPECT_EQ(0u, observer.errors().size());
+  EXPECT_TRUE(blacklist_check()->GetErrorMessage().empty());
+}
+
+// Tests that destroying the check after starting it does not cause errors.
+TEST_F(BlacklistCheckTest, StopCheck) {
+  SetBlacklistState(BLACKLISTED_MALWARE);
+
+  PreloadCheckObserver observer;
+  StartBlacklistCheck(&observer);
+  StopBlacklistCheck();
+  observer.Wait();
+
+  EXPECT_FALSE(observer.called());
+}
+
+}  // namespace extensions