OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2017 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #include "chrome/browser/extensions/blacklist_check.h" | |
Devlin
2017/03/14 01:44:34
grr... git cl format's include reordering isn't qu
michaelpg
2017/03/14 21:58:29
Done.
| |
6 #include "base/bind.h" | |
7 #include "base/threading/thread_task_runner_handle.h" | |
8 #include "chrome/browser/extensions/blacklist.h" | |
9 #include "chrome/browser/extensions/test_blacklist.h" | |
10 #include "chrome/browser/extensions/test_extension_prefs.h" | |
11 #include "content/public/test/test_browser_thread_bundle.h" | |
12 #include "extensions/browser/extension_prefs.h" | |
13 #include "extensions/browser/preload_check.h" | |
14 #include "extensions/browser/preload_check_test_util.h" | |
15 #include "testing/gtest/include/gtest/gtest.h" | |
16 | |
17 namespace extensions { | |
18 namespace { | |
19 | |
20 class BlacklistCheckTest : public testing::Test { | |
21 public: | |
22 BlacklistCheckTest() | |
23 : test_prefs_(base::ThreadTaskRunnerHandle::Get()), | |
24 blacklist_(test_prefs_.prefs()) {} | |
25 | |
26 protected: | |
27 void SetUp() override { | |
28 test_blacklist_.Attach(&blacklist_); | |
29 extension_ = test_prefs_.AddExtension("foo"); | |
30 } | |
31 | |
32 void SetBlacklistState(BlacklistState state) { | |
33 test_blacklist_.SetBlacklistState(extension_->id(), state, true); | |
Devlin
2017/03/14 01:44:34
doc anonymous bool
michaelpg
2017/03/14 21:58:29
Done.
| |
34 } | |
35 | |
36 void StartBlacklistCheck(PreloadCheckObserver* observer) { | |
37 blacklist_check_ = | |
38 base::MakeUnique<BlacklistCheck>(&blacklist_, extension_); | |
39 blacklist_check_->Start(base::Bind(&PreloadCheckObserver::OnCheckComplete, | |
40 base::Unretained(observer))); | |
41 } | |
42 | |
43 void StopBlacklistCheck() { blacklist_check_.reset(); } | |
Devlin
2017/03/14 01:44:34
nit: maybe s/Stop/Reset||Destroy? "Stop" seems so
michaelpg
2017/03/14 21:58:29
removed, but renamed test s/Stop/Reset
| |
44 | |
45 BlacklistCheck* blacklist_check() { return blacklist_check_.get(); } | |
46 | |
47 private: | |
48 content::TestBrowserThreadBundle browser_thread_bundle_; | |
49 TestExtensionPrefs test_prefs_; | |
50 Blacklist blacklist_; | |
51 TestBlacklist test_blacklist_; | |
52 scoped_refptr<Extension> extension_; | |
53 std::unique_ptr<BlacklistCheck> blacklist_check_; | |
54 }; | |
55 | |
56 } // namespace | |
57 | |
58 // Tests that the blacklist check identifies a blacklisted extension. | |
59 TEST_F(BlacklistCheckTest, BlacklistedMalware) { | |
60 SetBlacklistState(BLACKLISTED_MALWARE); | |
61 | |
62 PreloadCheckObserver observer; | |
63 StartBlacklistCheck(&observer); | |
64 observer.Wait(); | |
65 | |
66 EXPECT_TRUE(observer.called()); | |
67 EXPECT_EQ(1u, observer.errors().size()); | |
Devlin
2017/03/14 01:44:34
You could substitute these with:
EXPECT_THAT(obser
michaelpg
2017/03/14 21:58:29
sweet!
| |
68 EXPECT_EQ(1u, observer.errors().count(PreloadCheck::BLACKLISTED_ID)); | |
69 EXPECT_TRUE(blacklist_check()->GetErrorMessage().empty()); | |
70 } | |
71 | |
72 // Tests that the blacklist check ignores a non-blacklisted extension. | |
73 TEST_F(BlacklistCheckTest, Pass) { | |
74 SetBlacklistState(NOT_BLACKLISTED); | |
75 | |
76 PreloadCheckObserver observer; | |
77 StartBlacklistCheck(&observer); | |
78 observer.Wait(); | |
79 | |
80 EXPECT_TRUE(observer.called()); | |
81 EXPECT_EQ(0u, observer.errors().size()); | |
82 EXPECT_TRUE(blacklist_check()->GetErrorMessage().empty()); | |
83 } | |
84 | |
85 // Tests that destroying the check after starting it does not cause errors. | |
86 TEST_F(BlacklistCheckTest, StopCheck) { | |
87 SetBlacklistState(BLACKLISTED_MALWARE); | |
88 | |
89 PreloadCheckObserver observer; | |
90 StartBlacklistCheck(&observer); | |
91 StopBlacklistCheck(); | |
92 observer.Wait(); | |
93 | |
94 EXPECT_FALSE(observer.called()); | |
95 } | |
96 | |
97 } // namespace extensions | |
OLD | NEW |