Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2693363002: Move animation update to follow paint phase for SPv2. (Closed)
Patch Set: Update comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 5c587b2da1219ae46817e60a9c7ed7da00919e99..3469e0672e34f77a9244fd57f14496ebe0874d7d 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -3058,9 +3058,6 @@ void FrameView::updateLifecyclePhasesInternal(
prePaint();
}
- if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
- DocumentAnimations::updateAnimations(layoutView()->document());
-
if (targetState == DocumentLifecycle::PaintClean) {
if (!m_frame->document()->printing() ||
RuntimeEnabledFeatures::printBrowserEnabled())
@@ -3073,6 +3070,11 @@ void FrameView::updateLifecyclePhasesInternal(
DCHECK((m_frame->document()->printing() &&
lifecycle().state() == DocumentLifecycle::PrePaintClean) ||
lifecycle().state() == DocumentLifecycle::PaintClean);
+
+ if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
+ DocumentAnimations::updateAnimations(layoutView()->document(),
+ DocumentLifecycle::PaintClean);
+ }
}
forAllNonThrottledFrameViews([](FrameView& frameView) {

Powered by Google App Engine
This is Rietveld 408576698