Move animation update to follow paint phase for SPv2.

third_party/WebKit/Source/core/animation/DocumentAnimations.cpp

Index: third_party/WebKit/Source/core/animation/DocumentAnimations.cpp
diff --git a/third_party/WebKit/Source/core/animation/DocumentAnimations.cpp b/third_party/WebKit/Source/core/animation/DocumentAnimations.cpp
index e7c249939038b681357b67e28aaa43b825104ae6..806b319ef9dfe6410d657e6e6051e18c27d0295e 100644
--- a/third_party/WebKit/Source/core/animation/DocumentAnimations.cpp
+++ b/third_party/WebKit/Source/core/animation/DocumentAnimations.cpp
@@ -65,11 +65,10 @@ void DocumentAnimations::updateAnimationTimingIfNeeded(Document& document) {
     updateAnimationTiming(document, TimingUpdateOnDemand);
 }
 
-void DocumentAnimations::updateAnimations(Document& document) {
-  if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled())
-    DCHECK(document.lifecycle().state() >= DocumentLifecycle::CompositingClean);
-  else
-    DCHECK(document.lifecycle().state() >= DocumentLifecycle::LayoutClean);
+void DocumentAnimations::updateAnimations(
+    Document& document,
+    DocumentLifecycle::LifecycleState requiredLifecycleState) {
+  DCHECK(document.lifecycle().state() >= requiredLifecycleState);

[wkorman, 2017/02/16 23:42:08]

Passing the state with which we DCHECK feels weird. The whole point of DCHECK is
more for the implementation methods such as this one to enforce their
preconditions. Having the callsite responsible for knowing the precondition and
passing it along is strange, see for example in the PaintLayerCompositor edit in
this change where we pass CompositingClean immediately after we've advanced
lifecycle to CompositingClean.

But the obvious alternatives were to either copy this method's logic into
SVGImage which I didn't like, or do something like passing a param (bool, enum,
or what have you) to specialize DCHECK further than just by REF::spv2 here. The
latter seemed like a messier version of what I've actually done here.

Open to thoughts.

[wkorman, 2017/02/17 19:35:14]

After sleeping on this I think it's ok.

 
   if (document.compositorPendingAnimations().update()) {
     DCHECK(document.view());