Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: third_party/WebKit/Source/core/animation/DocumentAnimations.cpp

Issue 2693363002: Move animation update to follow paint phase for SPv2. (Closed)
Patch Set: Update comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 bool DocumentAnimations::needsAnimationTimingUpdate(const Document& document) { 58 bool DocumentAnimations::needsAnimationTimingUpdate(const Document& document) {
59 return document.timeline().hasOutdatedAnimation() || 59 return document.timeline().hasOutdatedAnimation() ||
60 document.timeline().needsAnimationTimingUpdate(); 60 document.timeline().needsAnimationTimingUpdate();
61 } 61 }
62 62
63 void DocumentAnimations::updateAnimationTimingIfNeeded(Document& document) { 63 void DocumentAnimations::updateAnimationTimingIfNeeded(Document& document) {
64 if (needsAnimationTimingUpdate(document)) 64 if (needsAnimationTimingUpdate(document))
65 updateAnimationTiming(document, TimingUpdateOnDemand); 65 updateAnimationTiming(document, TimingUpdateOnDemand);
66 } 66 }
67 67
68 void DocumentAnimations::updateAnimations(Document& document) { 68 void DocumentAnimations::updateAnimations(
69 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) 69 Document& document,
70 DCHECK(document.lifecycle().state() >= DocumentLifecycle::CompositingClean); 70 DocumentLifecycle::LifecycleState requiredLifecycleState) {
71 else 71 DCHECK(document.lifecycle().state() >= requiredLifecycleState);
72 DCHECK(document.lifecycle().state() >= DocumentLifecycle::LayoutClean);
73 72
74 if (document.compositorPendingAnimations().update()) { 73 if (document.compositorPendingAnimations().update()) {
75 DCHECK(document.view()); 74 DCHECK(document.view());
76 document.view()->scheduleAnimation(); 75 document.view()->scheduleAnimation();
77 } 76 }
78 77
79 document.timeline().scheduleNextService(); 78 document.timeline().scheduleNextService();
80 } 79 }
81 80
82 } // namespace blink 81 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/animation/DocumentAnimations.h ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698