Pull Chromium dependencies to Pipa checkout via DEPS and GITDEPS.

Pull needed Chromium dependencies to Pipa checkout via DEPS and GITDEPS.

BUG=
R=ftirelo@chromium.org

Committed: https://chromium.googlesource.com/chromium/pipa/+/ba39e17de34023d65d0d850d85537246894864be

[veranika, 2017-02-15 16:18:18]

Description was changed from

==========
Pull Chromium dependencies to Pipa checkout via DEPS and GITDEPS.

BUG=
==========

to

==========
Pull needed Chromium dependencies to Pipa checkout via DEPS and GITDEPS.

BUG=
==========

[veranika, 2017-02-15 16:18:40]

veranika@chromium.org changed reviewers:
+ ftirelo@chromium.org

[ftirelo, 2017-02-15 18:02:16]

LGTM with some nits and a question.

https://codereview.chromium.org/2693343002/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/2693343002/diff/20001/DEPS#newcode30
DEPS:30: include_rules = [
Please add base, build, gmock, gtest.

https://codereview.chromium.org/2693343002/diff/20001/GITDEPS
File GITDEPS (right):

https://codereview.chromium.org/2693343002/diff/20001/GITDEPS#newcode19
GITDEPS:19: "chrome_revision": "a691a7278a6f58da832b8818d2d00afa0687cd0d",
This will be used for the standalone version, right? In that case, would it make
sense to pull chromium at HEAD instead? In case we need to update the cleaner
code, we pull deps there.

https://codereview.chromium.org/2693343002/diff/20001/README.md
File README.md (right):

https://codereview.chromium.org/2693343002/diff/20001/README.md#newcode5
README.md:5: ## Checkout:
Can it be written in a single code block as:

```
mkdir pipa
cd pipa
gclient config --spec="solutions=[{'name':'src',
'url':'https://chromium.googlesource.com/chromium/pipa',},]"
gclient sync
```

[veranika, 2017-02-15 20:47:12]

PTAL.

https://codereview.chromium.org/2693343002/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/2693343002/diff/20001/DEPS#newcode30
DEPS:30: include_rules = [
On 2017/02/15 18:02:15, ftirelo wrote:
> Please add base, build, gmock, gtest.

All Chromium subtrees are pulled in GITDEPS. base, build and testing are there.

https://codereview.chromium.org/2693343002/diff/20001/GITDEPS
File GITDEPS (right):

https://codereview.chromium.org/2693343002/diff/20001/GITDEPS#newcode19
GITDEPS:19: "chrome_revision": "a691a7278a6f58da832b8818d2d00afa0687cd0d",
On 2017/02/15 18:02:16, ftirelo wrote:
> This will be used for the standalone version, right? In that case, would it
make
> sense to pull chromium at HEAD instead? In case we need to update the cleaner
> code, we pull deps there.

Doing so will require some changes in the gitdeps.py script. I would prefer this
commit to contain only copy of the original script, so I'll send another CL for
doing so.

https://codereview.chromium.org/2693343002/diff/20001/README.md
File README.md (right):

https://codereview.chromium.org/2693343002/diff/20001/README.md#newcode5
README.md:5: ## Checkout:
On 2017/02/15 18:02:16, ftirelo wrote:
> Can it be written in a single code block as:
> 
> ```
> mkdir pipa
> cd pipa
> gclient config --spec="solutions=[{'name':'src',
> 'url':'https://chromium.googlesource.com/chromium/pipa',},]"
> gclient sync
> ```

Done.

[ftirelo, 2017-02-16 01:37:28]

lgtm

[veranika, 2017-02-16 14:48:46]

Description was changed from

==========
Pull needed Chromium dependencies to Pipa checkout via DEPS and GITDEPS.

BUG=
==========

to

==========
Pull needed Chromium dependencies to Pipa checkout via DEPS and GITDEPS.

BUG=
R=ftirelo@chromium.org

Committed:
https://chromium.googlesource.com/chromium/pipa/+/ba39e17de34023d65d0d850d855...
==========

[veranika, 2017-02-16 14:48:48]

Committed patchset #3 (id:40001) manually as
ba39e17de34023d65d0d850d85537246894864be (presubmit successful).