Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: src/ast/scopes.h

Issue 2693313002: [ast] Mark temporaries as maybe-assigned by default. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | src/parsing/parser.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.h
diff --git a/src/ast/scopes.h b/src/ast/scopes.h
index 1947a266c1637d162595d4297d066b8ae42bd24e..8a9422b67086f2a1209e4e3acadc6c569902a913 100644
--- a/src/ast/scopes.h
+++ b/src/ast/scopes.h
@@ -210,8 +210,10 @@ class V8_EXPORT_PRIVATE Scope : public NON_EXPORTED_BASE(ZoneObject) {
// In particular, the only way to get hold of the temporary is by keeping the
// Variable* around. The name should not clash with a legitimate variable
// names.
+ // Only pass kNotAssigned if you know what you are doing.
adamk 2017/02/15 19:03:59 Not sure this comment is helpful. If this is dange
// TODO(verwaest): Move to DeclarationScope?
- Variable* NewTemporary(const AstRawString* name);
+ Variable* NewTemporary(const AstRawString* name,
+ MaybeAssignedFlag maybe_assigned = kMaybeAssigned);
// ---------------------------------------------------------------------------
// Illegal redeclaration support.
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | src/parsing/parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698